summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2010-11-15 11:17:52 -0800
committerGreg Kroah-Hartman <gregkh@suse.de>2010-12-09 13:24:18 -0800
commitd5f1f27112f1c969a6dc8ea9984fe6777b5344e3 (patch)
treebd59aeb8aee1cafd29ab5bfbdbe09f384f6f4bac
parentacfaf795b87fa4f34022a2c127930848a93742d3 (diff)
downloadlwn-d5f1f27112f1c969a6dc8ea9984fe6777b5344e3.tar.gz
lwn-d5f1f27112f1c969a6dc8ea9984fe6777b5344e3.zip
USB: storage: sierra_ms: fix sysfs file attribute
commit d9624e75f6ad94d8a0718c1fafa89186d271a78c upstream. A non-writable sysfs file shouldn't have writable attributes. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Kevin Lloyd <klloyd@sierrawireless.com> Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/storage/sierra_ms.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
index 4359a2cb42df..78ed40e919db 100644
--- a/drivers/usb/storage/sierra_ms.c
+++ b/drivers/usb/storage/sierra_ms.c
@@ -120,7 +120,7 @@ static ssize_t show_truinst(struct device *dev, struct device_attribute *attr,
}
return result;
}
-static DEVICE_ATTR(truinst, S_IWUGO | S_IRUGO, show_truinst, NULL);
+static DEVICE_ATTR(truinst, S_IRUGO, show_truinst, NULL);
int sierra_ms_init(struct us_data *us)
{