diff options
| author | Vasiliy Kulikov <segooon@gmail.com> | 2010-11-06 17:41:35 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-12-09 13:24:17 -0800 |
| commit | a4548d087ffaaecc406518cc3dfae2c92a28aea2 (patch) | |
| tree | 818dc3f5c69a94cfceb62349aae5067916c36607 | |
| parent | 330b3db2ccf393581e2c06d2cb36e0689dd585e3 (diff) | |
| download | lwn-a4548d087ffaaecc406518cc3dfae2c92a28aea2.tar.gz lwn-a4548d087ffaaecc406518cc3dfae2c92a28aea2.zip | |
usb: misc: sisusbvga: fix information leak to userland
commit 5dc92cf1d0b4b0debbd2e333b83f9746c103533d upstream.
Structure sisusb_info is copied to userland with "sisusb_reserved" field
uninitialized. It leads to leaking of contents of kernel stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/misc/sisusbvga/sisusb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c index 69c34a58e205..7c9a914973f7 100644 --- a/drivers/usb/misc/sisusbvga/sisusb.c +++ b/drivers/usb/misc/sisusbvga/sisusb.c @@ -3031,6 +3031,7 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg) #else x.sisusb_conactive = 0; #endif + memset(x.sisusb_reserved, 0, sizeof(x.sisusb_reserved)); if (copy_to_user((void __user *)arg, &x, sizeof(x))) retval = -EFAULT; |