diff options
| author | Vasiliy Kulikov <segooon@gmail.com> | 2010-10-30 18:22:49 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-12-09 13:24:17 -0800 |
| commit | 77f5c399311bd4a6d8836dbd788dd0e45a582d15 (patch) | |
| tree | 4aeef8e0c7eeed930ea9670f706ba2fcd99d9f77 | |
| parent | f6d7c2efda237f01fedc31965d056226e0df6a1d (diff) | |
| download | lwn-77f5c399311bd4a6d8836dbd788dd0e45a582d15.tar.gz lwn-77f5c399311bd4a6d8836dbd788dd0e45a582d15.zip | |
ipc: shm: fix information leak to userland
commit 3af54c9bd9e6f14f896aac1bb0e8405ae0bc7a44 upstream.
The shmid_ds structure is copied to userland with shm_unused{,2,3}
fields unitialized. It leads to leaking of contents of kernel stack
memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | ipc/shm.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ipc/shm.c b/ipc/shm.c index 37caa449e9ec..dfca4d839112 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -469,6 +469,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_ { struct shmid_ds out; + memset(&out, 0, sizeof(out)); ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm); out.shm_segsz = in->shm_segsz; out.shm_atime = in->shm_atime; |