diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2009-02-06 00:30:05 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-02-12 09:31:11 -0800 |
| commit | de6470415bc59d9d5736799c0803c6103b7d86b9 (patch) | |
| tree | 31e661be7a6f42f3fa8ee086628bd2ef980c1419 | |
| parent | 8115a6b9b94b36992affec7645e53c49e66cb8b1 (diff) | |
| download | lwn-de6470415bc59d9d5736799c0803c6103b7d86b9.tar.gz lwn-de6470415bc59d9d5736799c0803c6103b7d86b9.zip | |
seq_file: fix big-enough lseek() + read()
commit f01d1d546abb2f4028b5299092f529eefb01253a upstream.
lseek() further than length of the file will leave stale ->index
(second-to-last during iteration). Next seq_read() will not notice
that ->f_pos is big enough to return 0, but will print last item
as if ->f_pos is pointing to it.
Introduced in commit cb510b8172602a66467f3551b4be1911f5a7c8c2
aka "seq_file: more atomicity in traverse()".
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | fs/seq_file.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/seq_file.c b/fs/seq_file.c index 704e5a8e6647..ef4d4970a7d0 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -102,6 +102,7 @@ static int traverse(struct seq_file *m, loff_t offset) p = m->op->next(m, p, &index); } m->op->stop(m, p); + m->index = index; return error; Eoverflow: |