diff options
| author | PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com> | 2008-04-28 11:56:22 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-05-01 14:44:39 -0700 |
| commit | fa455bcd0a6460ef6543ebb212940fedf9f3170f (patch) | |
| tree | facf82a6bf76e901f3c363e15ceec31ab3a188c5 | |
| parent | 6ba675d46b278f478a22639b1c25b1476afcc351 (diff) | |
| download | lwn-fa455bcd0a6460ef6543ebb212940fedf9f3170f.tar.gz lwn-fa455bcd0a6460ef6543ebb212940fedf9f3170f.zip | |
x86: Fix 32-bit x86 MSI-X allocation leakage
commit 9d9ad4b51d2b29b5bbeb4011f5e76f7538119cf9 upstream
This bug was introduced in the 2.6.24 lguest merge, where
MSI-X vector allocation will eventually fail. The cause is the new
bit array tracking used vectors is not getting cleared properly on
IRQ destruction on the 32-bit APIC code.
This can be seen easily using the ixgbe 10 GbE driver on multi-core
systems by simply loading and unloading the driver a few times.
Depending on the number of available vectors on the host system, the
MSI-X allocation will eventually fail, and the driver will only be
able to use legacy interrupts.
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | arch/x86/kernel/io_apic_32.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c index 4ca548632c8d..f239b302e9ff 100644 --- a/arch/x86/kernel/io_apic_32.c +++ b/arch/x86/kernel/io_apic_32.c @@ -2477,6 +2477,7 @@ void destroy_irq(unsigned int irq) dynamic_irq_cleanup(irq); spin_lock_irqsave(&vector_lock, flags); + clear_bit(irq_vector[irq], used_vectors); irq_vector[irq] = 0; spin_unlock_irqrestore(&vector_lock, flags); } |