diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:45:16 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-05-01 14:44:39 -0700 |
| commit | b0cc38c177802742d847469e0a06f4ad31d011cc (patch) | |
| tree | 175dc2dc84ce0be5385c5a86afaba8afd0df3569 | |
| parent | f5f5e084959d9c22c43c235b206b2e2fe2971e7f (diff) | |
| download | lwn-b0cc38c177802742d847469e0a06f4ad31d011cc.tar.gz lwn-b0cc38c177802742d847469e0a06f4ad31d011cc.zip | |
drivers/net/tehuti: use proper capability check for raw IO access
commit 6203554207728f43cfb9fd48585cd6500da73d42 in mainline.
Yeah, in practice they both mean "root", but Alan correctly points out
that anybody who gets to do raw IO space accesses should really be using
CAP_SYS_RAWIO rather than CAP_NET_ADMIN.
Pointed-out-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/net/tehuti.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c index e83b166aa6b9..432e837a1760 100644 --- a/drivers/net/tehuti.c +++ b/drivers/net/tehuti.c @@ -649,7 +649,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd) DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]); } - if (!capable(CAP_NET_ADMIN)) + if (!capable(CAP_SYS_RAWIO)) return -EPERM; switch (data[0]) { |