diff options
| author | Jean Delvare <khali@linux-fr.org> | 2008-06-23 10:14:26 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-06-24 14:08:30 -0700 |
| commit | 73377b7ebafbb69016a6cf4342b65c560a85342e (patch) | |
| tree | c68d4c0149f827d9e379b3dc15dda91563452c03 | |
| parent | e5e3a8f78823da1e66b75f7bcc28626589fb650c (diff) | |
| download | lwn-73377b7ebafbb69016a6cf4342b65c560a85342e.tar.gz lwn-73377b7ebafbb69016a6cf4342b65c560a85342e.zip | |
hwmon: (lm85) Fix function RANGE_TO_REG()
Function RANGE_TO_REG() is broken. For a requested range of 2000 (2
degrees C), it will return an index value of 15, i.e. 80.0 degrees C,
instead of the expected index value of 0. All other values are handled
properly, just 2000 isn't.
The bug was introduced back in November 2004 by this patch:
http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commit;h=1c28d80f1992240373099d863e4996cdd5d646d0
In Linus' kernel I decided to rewrite the whole function in a way
which was more obviously correct. But for -stable let's just do the
minimal fix.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/hwmon/lm85.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c index 182fe6a5605f..30bdd508ea93 100644 --- a/drivers/hwmon/lm85.c +++ b/drivers/hwmon/lm85.c @@ -192,7 +192,7 @@ static int RANGE_TO_REG( int range ) { int i; - if ( range < lm85_range_map[0] ) { + if (range <= lm85_range_map[0]) { return 0 ; } else if ( range > lm85_range_map[15] ) { return 15 ; |