summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarc Pignat <marc.pignat@hevs.ch>2007-10-26 17:04:39 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2007-11-16 09:25:37 -0800
commitd866afcb920d41f24277e0986565a22e164e2720 (patch)
treeb32774647ced0b3867d45bdaf1999b804aef3535
parent90218467107c97a0b05aac332325f18e05b649e1 (diff)
downloadlwn-d866afcb920d41f24277e0986565a22e164e2720.tar.gz
lwn-d866afcb920d41f24277e0986565a22e164e2720.zip
zd1211rw, fix oops when ejecting install media
patch e0579d576cb894a4cf3c5af04fbf38e8c1281738 in mainline. The disconnect function can dereference the net_device structure when it is never allocated. This is the case when ejecting the device installer. Signed-off-by: Marc Pignat <marc.pignat@hevs.ch> Acked-by: Daniel Drake <dsd@gentoo.org> Signed-off-by: John W. Linville <linville@tuxdriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/net/wireless/zd1211rw/zd_usb.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/wireless/zd1211rw/zd_usb.c b/drivers/net/wireless/zd1211rw/zd_usb.c
index a9c339ef116a..53263015c8f1 100644
--- a/drivers/net/wireless/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zd1211rw/zd_usb.c
@@ -1041,14 +1041,17 @@ error:
static void disconnect(struct usb_interface *intf)
{
struct net_device *netdev = zd_intf_to_netdev(intf);
- struct zd_mac *mac = zd_netdev_mac(netdev);
- struct zd_usb *usb = &mac->chip.usb;
+ struct zd_mac *mac;
+ struct zd_usb *usb;
/* Either something really bad happened, or we're just dealing with
* a DEVICE_INSTALLER. */
if (netdev == NULL)
return;
+ mac = zd_netdev_mac(netdev);
+ usb = &mac->chip.usb;
+
dev_dbg_f(zd_usb_dev(usb), "\n");
zd_netdev_disconnect(netdev);