diff options
author | Arne Redlich <agr@powerkom-dd.de> | 2007-07-31 00:37:57 -0700 |
---|---|---|
committer | Willy Tarreau <w@1wt.eu> | 2007-08-25 17:24:06 +0200 |
commit | 32c207fa861f29aad527039da70556b5c387a2be (patch) | |
tree | acdd5c2d8315386b3f15da08cb4318d51dfeefb4 | |
parent | dd6de5b299db5ca6e81f3237bf61610921ab5933 (diff) | |
download | lwn-32c207fa861f29aad527039da70556b5c387a2be.tar.gz lwn-32c207fa861f29aad527039da70556b5c387a2be.zip |
[PATCH] md: handle writes to broken raid10 arrays gracefully
When writing to a broken array, raid10 currently happily emits empty bio
lists. IOW, the master bio will never be completed, sending writers to
UNINTERRUPTIBLE_SLEEP forever.
Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
Acked-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
-rw-r--r-- | drivers/md/raid10.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 9eb66c1b523b..fb5d9c6e9de0 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -917,6 +917,13 @@ static int make_request(request_queue_t *q, struct bio * bio) bio_list_add(&bl, mbio); } + if (unlikely(!atomic_read(&r10_bio->remaining))) { + /* the array is dead */ + md_write_end(mddev); + raid_end_bio_io(r10_bio); + return 0; + } + bitmap_startwrite(mddev->bitmap, bio->bi_sector, r10_bio->sectors, 0); spin_lock_irqsave(&conf->device_lock, flags); bio_list_merge(&conf->pending_bio_list, &bl); |