summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Graf <tgraf@suug.ch>2006-11-07 15:34:27 +0100
committerAdrian Bunk <bunk@stusta.de>2006-11-07 15:34:27 +0100
commitaa459cd3ef50097e5f6f3b659a0b28f740fd5c1c (patch)
tree8cbea63d9cc668ca9e963ac88c75442369937245
parented382a2a0f26e182f17743891b4a9eb44a659310 (diff)
downloadlwn-aa459cd3ef50097e5f6f3b659a0b28f740fd5c1c.tar.gz
lwn-aa459cd3ef50097e5f6f3b659a0b28f740fd5c1c.zip
[PKT_SCHED]: act_api: Fix module leak while flushing actions
Module reference needs to be given back if message header construction fails. Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Adrian Bunk <bunk@stusta.de>
-rw-r--r--net/sched/act_api.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index eb7dc2947a0a..a9fab455df08 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -603,8 +603,8 @@ static int tca_action_flush(struct rtattr *rta, struct nlmsghdr *n, u32 pid)
return err;
rtattr_failure:
- module_put(a->ops->owner);
nlmsg_failure:
+ module_put(a->ops->owner);
err_out:
kfree_skb(skb);
kfree(a);