diff options
| author | Patrick McHardy <kaber@trash.net> | 2005-09-13 09:37:22 +0200 |
|---|---|---|
| committer | Chris Wright <chrisw@osdl.org> | 2005-09-16 18:01:57 -0700 |
| commit | 504b891bc7cc7fb76e3000b5fe91ca491eb773c5 (patch) | |
| tree | 7ccb23508b9ac3ff43cca9ec0c0158fe0bdaa5c9 | |
| parent | 6829c71237ca54f1b752520ba06eacdae68249dc (diff) | |
| download | lwn-504b891bc7cc7fb76e3000b5fe91ca491eb773c5.tar.gz lwn-504b891bc7cc7fb76e3000b5fe91ca491eb773c5.zip | |
[PATCH] Fix DHCP + MASQUERADE problem
In 2.6.13-rcX the MASQUERADE target was changed not to exclude local
packets for better source address consistency. This breaks DHCP clients
using UDP sockets when the DHCP requests are caught by a MASQUERADE rule
because the MASQUERADE target drops packets when no address is configured
on the outgoing interface. This patch makes it ignore packets with a
source address of 0.
Thanks to Rusty for this suggestion.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Chris Wright <chrisw@osdl.org>
| -rw-r--r-- | net/ipv4/netfilter/ipt_MASQUERADE.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/ipv4/netfilter/ipt_MASQUERADE.c b/net/ipv4/netfilter/ipt_MASQUERADE.c index 91e74502c3d3..4c8d6ef423bc 100644 --- a/net/ipv4/netfilter/ipt_MASQUERADE.c +++ b/net/ipv4/netfilter/ipt_MASQUERADE.c @@ -95,6 +95,12 @@ masquerade_target(struct sk_buff **pskb, IP_NF_ASSERT(ct && (ctinfo == IP_CT_NEW || ctinfo == IP_CT_RELATED || ctinfo == IP_CT_RELATED + IP_CT_IS_REPLY)); + /* Source address is 0.0.0.0 - locally generated packet that is + * probably not supposed to be masqueraded. + */ + if (ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.ip == 0) + return NF_ACCEPT; + mr = targinfo; rt = (struct rtable *)(*pskb)->dst; newsrc = inet_select_addr(out, rt->rt_gateway, RT_SCOPE_UNIVERSE); |