diff options
| author | Riwen Lu <luriwen@kylinos.cn> | 2021-06-04 11:09:59 +0800 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2021-06-09 11:51:30 -0700 |
| commit | 78d13552346289bad4a9bf8eabb5eec5e5a321a5 (patch) | |
| tree | ea796e8b5df1f514e144784e9820bc9d26f8111b | |
| parent | 7656cd2177612aa7c299b083ecff30a4d3e9a587 (diff) | |
| download | lwn-78d13552346289bad4a9bf8eabb5eec5e5a321a5.tar.gz lwn-78d13552346289bad4a9bf8eabb5eec5e5a321a5.zip | |
hwmon: (scpi-hwmon) shows the negative temperature properly
The scpi hwmon shows the sub-zero temperature in an unsigned integer,
which would confuse the users when the machine works in low temperature
environment. This shows the sub-zero temperature in an signed value and
users can get it properly from sensors.
Signed-off-by: Riwen Lu <luriwen@kylinos.cn>
Tested-by: Xin Chen <chenxin@kylinos.cn>
Link: https://lore.kernel.org/r/20210604030959.736379-1-luriwen@kylinos.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/scpi-hwmon.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c index 25aac40f2764..919877970ae3 100644 --- a/drivers/hwmon/scpi-hwmon.c +++ b/drivers/hwmon/scpi-hwmon.c @@ -99,6 +99,15 @@ scpi_show_sensor(struct device *dev, struct device_attribute *attr, char *buf) scpi_scale_reading(&value, sensor); + /* + * Temperature sensor values are treated as signed values based on + * observation even though that is not explicitly specified, and + * because an unsigned u64 temperature does not really make practical + * sense especially when the temperature is below zero degrees Celsius. + */ + if (sensor->info.class == TEMPERATURE) + return sprintf(buf, "%lld\n", (s64)value); + return sprintf(buf, "%llu\n", value); } |