diff options
| author | Ziyang Xuan <william.xuanziyang@huawei.com> | 2021-10-13 15:50:32 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-10-13 17:44:29 -0700 |
| commit | 291c932fc3692e4d211a445ba8aa35663831bac7 (patch) | |
| tree | 1178e0802a707fcadd60aedfee8327c20b31ece5 | |
| parent | 58e7dcc9ca29c14e44267a4d0ea61e3229124907 (diff) | |
| download | lwn-291c932fc3692e4d211a445ba8aa35663831bac7.tar.gz lwn-291c932fc3692e4d211a445ba8aa35663831bac7.zip | |
NFC: digital: fix possible memory leak in digital_in_send_sdd_req()
'skb' is allocated in digital_in_send_sdd_req(), but not free when
digital_in_send_cmd() failed, which will cause memory leak. Fix it
by freeing 'skb' if digital_in_send_cmd() return failed.
Fixes: 2c66daecc409 ("NFC Digital: Add NFC-A technology support")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/nfc/digital_technology.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/net/nfc/digital_technology.c b/net/nfc/digital_technology.c index 84d2345c75a3..3adf4589852a 100644 --- a/net/nfc/digital_technology.c +++ b/net/nfc/digital_technology.c @@ -465,8 +465,12 @@ static int digital_in_send_sdd_req(struct nfc_digital_dev *ddev, skb_put_u8(skb, sel_cmd); skb_put_u8(skb, DIGITAL_SDD_REQ_SEL_PAR); - return digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sdd_res, - target); + rc = digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sdd_res, + target); + if (rc) + kfree_skb(skb); + + return rc; } static void digital_in_recv_sens_res(struct nfc_digital_dev *ddev, void *arg, |