diff options
| author | Uwe Kleine-König <ukleinek@baylibre.com> | 2024-06-07 10:44:17 +0200 |
|---|---|---|
| committer | Uwe Kleine-König <ukleinek@kernel.org> | 2024-07-10 17:52:47 +0200 |
| commit | d6f66e292676db976c4d42df2631427236c36fdb (patch) | |
| tree | a744cb6c252955d9efd598815caef81b4e9ee3df | |
| parent | 40571a5b3b73c6c5189e55ff82b97a58bec371a1 (diff) | |
| download | lwn-d6f66e292676db976c4d42df2631427236c36fdb.tar.gz lwn-d6f66e292676db976c4d42df2631427236c36fdb.zip | |
pwm: Make pwm_request_from_chip() private to the core
The last user of this function outside of core.c is gone, so it can be
made static.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20240607084416.897777-8-u.kleine-koenig@baylibre.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
| -rw-r--r-- | drivers/pwm/core.c | 8 | ||||
| -rw-r--r-- | include/linux/pwm.h | 12 |
2 files changed, 3 insertions, 17 deletions
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 604fd9bc8f22..5c1d20985148 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -396,9 +396,9 @@ err_get_device: * chip. A negative error code is returned if the index is not valid for the * specified PWM chip or if the PWM device cannot be requested. */ -struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip, - unsigned int index, - const char *label) +static struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip, + unsigned int index, + const char *label) { struct pwm_device *pwm; int err; @@ -416,8 +416,6 @@ struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip, mutex_unlock(&pwm_lock); return pwm; } -EXPORT_SYMBOL_GPL(pwm_request_from_chip); - struct pwm_device * of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *args) diff --git a/include/linux/pwm.h b/include/linux/pwm.h index 812c550de60c..2e225f3b4282 100644 --- a/include/linux/pwm.h +++ b/include/linux/pwm.h @@ -410,10 +410,6 @@ void pwmchip_remove(struct pwm_chip *chip); int __devm_pwmchip_add(struct device *dev, struct pwm_chip *chip, struct module *owner); #define devm_pwmchip_add(dev, chip) __devm_pwmchip_add(dev, chip, THIS_MODULE) -struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip, - unsigned int index, - const char *label); - struct pwm_device *of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *args); struct pwm_device *of_pwm_single_xlate(struct pwm_chip *chip, @@ -508,14 +504,6 @@ static inline int devm_pwmchip_add(struct device *dev, struct pwm_chip *chip) return -EINVAL; } -static inline struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip, - unsigned int index, - const char *label) -{ - might_sleep(); - return ERR_PTR(-ENODEV); -} - static inline struct pwm_device *pwm_get(struct device *dev, const char *consumer) { |