diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2023-11-12 17:03:14 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2023-12-21 12:53:21 -0500 |
| commit | b64b0732c3eec11783dd6bb12757dc04395a73e1 (patch) | |
| tree | b8adef19a259741b511e87c082308fe24cbeda35 | |
| parent | 556f38bf457fee5d9f3ede65b67fd91dd2ea2ca1 (diff) | |
| download | lwn-b64b0732c3eec11783dd6bb12757dc04395a73e1.tar.gz lwn-b64b0732c3eec11783dd6bb12757dc04395a73e1.zip | |
__ocfs2_add_entry(), ocfs2_prepare_dir_for_insert(): namelen checks
namelen can't be zero; neither when it's coming from dentry name,
nor when dealing with orphans (in ocfs2_orphan_add() and
__ocfs2_prepare_orphan_dir()). Rudiment of old ext2 pointless
check, long gone in ext2 itself...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | fs/ocfs2/dir.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index a14c8fee6ee5..d620d4c53c6f 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -1593,9 +1593,6 @@ int __ocfs2_add_entry(handle_t *handle, struct buffer_head *insert_bh = lookup->dl_leaf_bh; char *data_start = insert_bh->b_data; - if (!namelen) - return -EINVAL; - if (ocfs2_dir_indexed(dir)) { struct buffer_head *bh; @@ -4245,12 +4242,6 @@ int ocfs2_prepare_dir_for_insert(struct ocfs2_super *osb, trace_ocfs2_prepare_dir_for_insert( (unsigned long long)OCFS2_I(dir)->ip_blkno, namelen); - if (!namelen) { - ret = -EINVAL; - mlog_errno(ret); - goto out; - } - /* * Do this up front to reduce confusion. * |