summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRevanth Rajashekar <revanth.rajashekar@intel.com>2019-06-27 16:31:09 -0600
committerJens Axboe <axboe@kernel.dk>2019-06-29 09:40:31 -0600
commit15ddffcb341392ba56a28a0ff5d19d8f8cde1b80 (patch)
tree9db30c853a83c8919c42f717d2e29b9133bb42c2
parent5e4c7cf60ec3cad59703c203de1dfb31ea608e6e (diff)
downloadlwn-15ddffcb341392ba56a28a0ff5d19d8f8cde1b80.tar.gz
lwn-15ddffcb341392ba56a28a0ff5d19d8f8cde1b80.zip
block: sed-opal: "Never True" conditions
'who' an unsigned variable in stucture opal_session_info can never be lesser than zero. Hence, the condition "who < OPAL_ADMIN1" can never be true. Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--block/sed-opal.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/block/sed-opal.c b/block/sed-opal.c
index bb8ef7963d11..c54019c11e91 100644
--- a/block/sed-opal.c
+++ b/block/sed-opal.c
@@ -2114,8 +2114,7 @@ static int opal_lock_unlock(struct opal_dev *dev,
{
int ret;
- if (lk_unlk->session.who < OPAL_ADMIN1 ||
- lk_unlk->session.who > OPAL_USER9)
+ if (lk_unlk->session.who > OPAL_USER9)
return -EINVAL;
mutex_lock(&dev->dev_lock);
@@ -2193,9 +2192,7 @@ static int opal_set_new_pw(struct opal_dev *dev, struct opal_new_pw *opal_pw)
};
int ret;
- if (opal_pw->session.who < OPAL_ADMIN1 ||
- opal_pw->session.who > OPAL_USER9 ||
- opal_pw->new_user_pw.who < OPAL_ADMIN1 ||
+ if (opal_pw->session.who > OPAL_USER9 ||
opal_pw->new_user_pw.who > OPAL_USER9)
return -EINVAL;