diff options
| author | Vegard Nossum <vegard.nossum@oracle.com> | 2024-02-05 18:51:26 +0100 |
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2024-02-08 11:05:35 -0700 |
| commit | c23de7ceae59e4ca5894c3ecf4f785c50c0fa428 (patch) | |
| tree | b1704e727a3ac9864fddc94d1685aeaf3880043c | |
| parent | d546978e0c07b6333fdbcbd81b2f2e058d4560b5 (diff) | |
| download | lwn-c23de7ceae59e4ca5894c3ecf4f785c50c0fa428.tar.gz lwn-c23de7ceae59e4ca5894c3ecf4f785c50c0fa428.zip | |
docs: kernel_feat.py: fix build error for missing filesdocs-6.8-fixes2
If the directory passed to the '.. kernel-feat::' directive does not
exist or the get_feat.pl script does not find any files to extract
features from, Sphinx will report the following error:
Sphinx parallel build error:
UnboundLocalError: local variable 'fname' referenced before assignment
make[2]: *** [Documentation/Makefile:102: htmldocs] Error 2
This is due to how I changed the script in c48a7c44a1d0 ("docs:
kernel_feat.py: fix potential command injection"). Before that, the
filename passed along to self.nestedParse() in this case was weirdly
just the whole get_feat.pl invocation.
We can fix it by doing what kernel_abi.py does -- just pass
self.arguments[0] as 'fname'.
Fixes: c48a7c44a1d0 ("docs: kernel_feat.py: fix potential command injection")
Cc: Justin Forbes <jforbes@fedoraproject.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Link: https://lore.kernel.org/r/20240205175133.774271-2-vegard.nossum@oracle.com
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
| -rw-r--r-- | Documentation/sphinx/kernel_feat.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/sphinx/kernel_feat.py b/Documentation/sphinx/kernel_feat.py index b9df61eb4501..03ace5f01b5c 100644 --- a/Documentation/sphinx/kernel_feat.py +++ b/Documentation/sphinx/kernel_feat.py @@ -109,7 +109,7 @@ class KernelFeat(Directive): else: out_lines += line + "\n" - nodeList = self.nestedParse(out_lines, fname) + nodeList = self.nestedParse(out_lines, self.arguments[0]) return nodeList def nestedParse(self, lines, fname): |