summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNamjae Jeon <namjae.jeon@samsung.com>2021-05-26 15:53:26 +0900
committerNamjae Jeon <namjae.jeon@samsung.com>2021-05-26 18:12:53 +0900
commit73b8b08539423a888ed76b53401a6366e0e2af2b (patch)
tree178a49914857535eb4e29269907beda956d84147
parent27aa646db0f0465c5abf8e5cd545e070e7f14120 (diff)
downloadlwn-73b8b08539423a888ed76b53401a6366e0e2af2b.tar.gz
lwn-73b8b08539423a888ed76b53401a6366e0e2af2b.zip
cifsd: change success handling to failure handling
Change success handling to failure handling in ksmbd_crypt_message(). Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Steve French <stfrench@microsoft.com>
-rw-r--r--fs/cifsd/auth.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/cifsd/auth.c b/fs/cifsd/auth.c
index 5a56dd65fa06..b0a9e4591fa5 100644
--- a/fs/cifsd/auth.c
+++ b/fs/cifsd/auth.c
@@ -1331,9 +1331,13 @@ int ksmbd_crypt_message(struct ksmbd_conn *conn, struct kvec *iov,
rc = crypto_aead_encrypt(req);
else
rc = crypto_aead_decrypt(req);
- if (!rc && enc)
+ if (rc)
+ goto free_iv;
+
+ if (enc)
memcpy(&tr_hdr->Signature, sign, SMB2_SIGNATURE_SIZE);
+free_iv:
kfree(iv);
free_sg:
kfree(sg);