diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-12-03 12:55:31 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-12-03 14:22:00 +0000 |
| commit | bb14bfc7eb927b47717d82ba7ecc8345d9099cf4 (patch) | |
| tree | 9cb9aca35f36151235760b34c34605fdc7f2422c | |
| parent | f6882b8fac60f928fda51efc64274463806f956c (diff) | |
| download | lwn-bb14bfc7eb927b47717d82ba7ecc8345d9099cf4.tar.gz lwn-bb14bfc7eb927b47717d82ba7ecc8345d9099cf4.zip | |
net: lan966x: fix a IS_ERR() vs NULL check in lan966x_create_targets()
The devm_ioremap() function does not return error pointers. It returns
NULL.
Fixes: db8bcaad5393 ("net: lan966x: add the basic lan966x driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c index be5e2b3a7f43..101c1f005baf 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c @@ -83,10 +83,10 @@ static int lan966x_create_targets(struct platform_device *pdev, begin[idx] = devm_ioremap(&pdev->dev, iores[idx]->start, resource_size(iores[idx])); - if (IS_ERR(begin[idx])) { + if (!begin[idx]) { dev_err(&pdev->dev, "Unable to get registers: %s\n", iores[idx]->name); - return PTR_ERR(begin[idx]); + return -ENOMEM; } } |