summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSonny Rao <sonny@burdell.org>2006-06-27 02:54:06 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-27 17:32:40 -0700
commit6ac12dfe9c2027cd3c5ed603f11d1bb4f04906fe (patch)
tree7c1cb6d405dcaf959d9b1f67f62991775722fcde
parentb65b5b59f98aa317df399318b0b2770f50732d3c (diff)
downloadlwn-6ac12dfe9c2027cd3c5ed603f11d1bb4f04906fe.tar.gz
lwn-6ac12dfe9c2027cd3c5ed603f11d1bb4f04906fe.zip
[PATCH] rtc: fix idr locking
We need to serialize access to the global rtc_idr even in this error path. Signed-off-by: Sonny Rao <sonny@burdell.org> Acked-by: Alessandro Zummo <a.zummo@towertech.it> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/rtc/class.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
index 5396beec30d0..1cb61a761cb2 100644
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -94,7 +94,9 @@ exit_kfree:
kfree(rtc);
exit_idr:
+ mutex_lock(&idr_lock);
idr_remove(&rtc_idr, id);
+ mutex_unlock(&idr_lock);
exit:
dev_err(dev, "rtc core: unable to register %s, err = %d\n",