summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRusty Russell <rusty@rustcorp.com.au>2014-08-07 22:38:55 +0930
committerRusty Russell <rusty@rustcorp.com.au>2014-08-07 22:38:55 +0930
commit76215b04fd297c008b91ece732ed36e67e0181fa (patch)
tree9652745f802963e68d5a2111213a7371017a13c8
parent6656c21ca10e54a84673d0ec2f0cf5f676e66a40 (diff)
downloadlwn-76215b04fd297c008b91ece732ed36e67e0181fa.tar.gz
lwn-76215b04fd297c008b91ece732ed36e67e0181fa.zip
arch/powerpc/platforms/powernv/opal-dump.c: fix world-writable sysfs files
If you don't have a store function, you're not writable anyway! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-rw-r--r--arch/powerpc/platforms/powernv/opal-dump.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c
index 788a1977b9a5..85bb8fff7947 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv/opal-dump.c
@@ -102,9 +102,9 @@ static ssize_t dump_ack_store(struct dump_obj *dump_obj,
* due to the dynamic size of the dump
*/
static struct dump_attribute id_attribute =
- __ATTR(id, 0666, dump_id_show, NULL);
+ __ATTR(id, S_IRUGO, dump_id_show, NULL);
static struct dump_attribute type_attribute =
- __ATTR(type, 0666, dump_type_show, NULL);
+ __ATTR(type, S_IRUGO, dump_type_show, NULL);
static struct dump_attribute ack_attribute =
__ATTR(acknowledge, 0660, dump_ack_show, dump_ack_store);