summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKirill Korotaev <dev@openvz.org>2006-01-09 17:42:42 +0300
committerLinus Torvalds <torvalds@g5.osdl.org>2006-01-09 09:36:52 -0800
commit14591de147f7c9656fa2b9c05680d2b46e286c40 (patch)
treee4c3a5d0da2f7f64d08ba6f10000e363f69889cd
parent677517771b7b6efaf8617e70f655b16f3cafcc9b (diff)
downloadlwn-14591de147f7c9656fa2b9c05680d2b46e286c40.tar.gz
lwn-14591de147f7c9656fa2b9c05680d2b46e286c40.zip
[PATCH] netlink oops fix due to incorrect error code
Fixed oops after failed netlink socket creation. Wrong parathenses in if() statement caused err to be 1, instead of negative value. Trivial fix, not trivial to find though. Signed-Off-By: Dmitry Mishin <dim@sw.ru> Signed-Off-By: Kirill Korotaev <dev@openvz.org> Signed-Off-By: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--net/netlink/af_netlink.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 7849cac14d3a..a67f1b44c9a3 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -402,7 +402,7 @@ static int netlink_create(struct socket *sock, int protocol)
groups = nl_table[protocol].groups;
netlink_unlock_table();
- if ((err = __netlink_create(sock, protocol) < 0))
+ if ((err = __netlink_create(sock, protocol)) < 0)
goto out_module;
nlk = nlk_sk(sock->sk);