diff options
| author | Carlos Jones Jr <carlosjr.jones@analog.com> | 2026-10-02 16:55:40 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-10-13 23:19:59 +0100 |
| commit | 8980bc573ae2d2b9d86d76aeb86c76e1597070bf (patch) | |
| tree | 3c5acec5bc5e695414bcaddbd962858563f648e3 /scripts/Makefile.thinlto | |
| parent | 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907 (diff) | |
| download | linux-next-8980bc573ae2d2b9d86d76aeb86c76e1597070bf.tar.gz linux-next-8980bc573ae2d2b9d86d76aeb86c76e1597070bf.zip | |
spi: tegra114: assert CS GPIO for every transfer in a message
The driver provides its own transfer_one_message() and therefore drives
the chip-select GPIO itself rather than through the SPI core. The GPIO is
asserted only in the is_first_of_msg path of
tegra_spi_setup_transfer_one(), but tegra_spi_transfer_end() deasserts it
whenever a transfer has cs_change set. For a multi-transfer message whose
earlier transfers request cs_change -- for example a register read that
sends the address in one transfer and clocks the data back in the next --
the CS GPIO is released after the first transfer and never re-asserted,
so the remaining transfers are clocked with chip-select inactive and the
peripheral never drives the bus.
This was observed with an ADIS16470 IMU (adis16475 driver), whose
register read is a two-transfer, cs_change-framed exchange: a logic
analyzer showed the data frame clocked with CS high, and the driver read
0 while the device drove 0x4056 on the wire.
Re-assert the CS GPIO for every transfer so that multi-transfer messages
keep chip-select active across the whole message. gpiod_set_value() is
idempotent and polarity-aware, so this is a no-op for the first transfer
and for messages that keep CS asserted throughout.
Fixes: 63c1440596ff ("spi: tegra114: add support for gpio based CS")
Signed-off-by: Carlos Jones Jr <carlosjr.jones@analog.com>
Link: https://patch.msgid.link/20261002085540.1625-1-carlosjr.jones@analog.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'scripts/Makefile.thinlto')
0 files changed, 0 insertions, 0 deletions
