lwn.git/sound/pci/cs4281.c, branch docs-4.14

ALSA: pci: make snd_pcm_hardware const

2017-08-12T21:31:58+00:00

Make these const as they are only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal Signed-off-by: Takashi Iwai

ALSA: cs4281: Fix the leftover comment

2017-05-17T05:13:07+00:00

The comment at endif line was forgotten to be corrected when the condition was converted to IS_REACHABLE(). Fix it, too. Signed-off-by: Takashi Iwai

ALSA: pci: constify snd_kcontrol_new structures

2017-02-21T21:01:21+00:00

Declare snd_kcontrol_new structures as const as they are only passed as an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having the same property can be made const too. Done using Coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct snd_kcontrol_new i@p = {...}; @ok1@ identifier r1.i; position p; expression e1; @@ snd_ctl_new1(&i@p,e1) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct snd_kcontrol_new i; Signed-off-by: Bhumika Goyal Signed-off-by: Takashi Iwai

ALSA: pci: Constify snd_rawmidi_ops

2017-01-12T11:50:26+00:00

Now snd_rawmidi_ops is maintained as a const pointer in snd_rawmidi, we can constify the definitions. Reviewed-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: pci: don't opencode IS_REACHABLE()

2016-11-13T20:33:41+00:00

Signed-off-by: Fabian Frederick Signed-off-by: Takashi Iwai

ALSA: constify snd_pcm_ops structures

2016-09-02T09:49:10+00:00

Check for snd_pcm_ops structures that are only stored in the ops field of a snd_soc_platform_driver structure or passed as the third argument to snd_pcm_set_ops. The corresponding field or parameter is declared const, so snd_pcm_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r disable optional_qualifier@ identifier i; position p; @@ static struct snd_pcm_ops i@p = { ... }; @ok1@ identifier r.i; struct snd_soc_platform_driver e; position p; @@ e.ops = &i@p; @ok2@ identifier r.i; expression e1, e2; position p; @@ snd_pcm_set_ops(e1, e2, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; struct snd_pcm_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct snd_pcm_ops i = { ... }; // Signed-off-by: Julia Lawall Signed-off-by: Takashi Iwai

ALSA: Include linux/io.h instead of asm/io.h

2015-01-28T15:49:33+00:00

Nowadays it's recommended. Replace all in a shot. Signed-off-by: Takashi Iwai

Merge branch 'topic/pci-cleanup' into for-next

2015-01-11T10:26:48+00:00

ALSA: cs4281: Simplify PM callbacks

2015-01-09T15:24:19+00:00

This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801: PCI core handles power state for us]. Since pci_set_power_state(), pci_save_state() and pci_restore_state() are already done in the PCI core side, so we don't need to it doubly. Also, pci_enable_device(), pci_disable_device() and pci_set_master() calls in PM callbacks are superfluous nowadays, too, so get rid of them as well. Signed-off-by: Takashi Iwai

ALSA: Deletion of checks before the function call "iounmap"

2015-01-04T14:13:45+00:00

The iounmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai