lwn.git/sound/pci/ad1889.c, branch v3.17-rc4

PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use

2014-08-12T18:15:14+00:00

We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const struct pci_device_id i[] = z; // [bhelgaas: add semantic patch] Signed-off-by: Benoit Taine Signed-off-by: Bjorn Helgaas

ALSA: ad1889: Use standard printk helpers

2014-02-26T15:45:10+00:00

Convert with dev_err() and co from snd_printk(), etc. Signed-off-by: Takashi Iwai

ALSA: pci: Convert to snd_card_new() with a device pointer

2014-02-12T10:17:52+00:00

Also remove superfluous snd_card_set_dev() calls. Signed-off-by: Takashi Iwai

ALSA: ad1889: Fix right attenuation proc output

2013-10-29T14:39:37+00:00

The right attenuation bits aren't needed to be shifted. Spotted by coverity CID 11427. Signed-off-by: Takashi Iwai

ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove

2013-05-29T10:37:32+00:00

As drvdata is cleared to NULL at probe failure or at removal by the driver core, we don't have to call pci_set_drvdata(pci, NULL) any longer in each driver. The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in hda_intel.c. Since this function itself releases the card instance, we need to clear drvdata here as well, so that it won't be released doubly in the remove callback. Signed-off-by: Takashi Iwai

ALSA: ad1889: remove __dev* attributes

2012-12-07T06:31:18+00:00

CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton Cc: Thibaut Varene Cc: linux-parisc@vger.kernel.org Signed-off-by: Takashi Iwai

ALSA: pci: clean up using module_pci_driver()

2012-04-24T10:25:00+00:00

Signed-off-by: Takashi Iwai

ALSA: module_param: make bool parameters really bool

2011-12-19T09:34:41+00:00

module_param(bool) used to counter-intuitively take an int. In fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy trick. It's time to remove the int/unsigned int option. For this version it'll simply give a warning, but it'll break next kernel version. Signed-off-by: Rusty Russell Signed-off-by: Takashi Iwai

sound: Add module.h to the previously silent sound users

2011-10-31T23:31:21+00:00

Lots of sound drivers were getting module.h via the implicit presence of it in but we are going to clean that up. So fix up those users now. Signed-off-by: Paul Gortmaker

ALSA: use KBUILD_MODNAME for request_irq argument in sound/pci/*

2011-06-10T14:36:37+00:00

The name argument of request_irq() appears in /proc/interrupts, and it's quite ugly when the name entry contains a space or special letters. In general, it's simpler and more readable when the module name appears there, so let's replace all entries with KBUILD_MODNAME. Signed-off-by: Takashi Iwai