lwn.git/net/mac80211/rx.c, branch v3.14.3

mac80211: fix station wakeup powersave race

2014-02-20T10:54:09+00:00

Consider the following (relatively unlikely) scenario: 1) station goes to sleep while frames are buffered in driver 2) driver blocks wakeup (until no more frames are buffered) 3) station wakes up again 4) driver unblocks wakeup In this case, the current mac80211 code will do the following: 1) WLAN_STA_PS_STA set 2) WLAN_STA_PS_DRIVER set 3) - nothing - 4) WLAN_STA_PS_DRIVER cleared As a result, no frames will be delivered to the client, even though it is awake, until it sends another frame to us that triggers ieee80211_sta_ps_deliver_wakeup() in sta_ps_end(). Since we now take the PS spinlock, we can fix this while at the same time removing the complexity with the pending skb queue function. This was broken since my commit 50a9432daeec ("mac80211: fix powersaving clients races") due to removing the clearing of WLAN_STA_PS_STA in the RX path. While at it, fix a cleanup path issue when a station is removed while the driver is still blocking its wakeup. Signed-off-by: Johannes Berg

mac80211: clean up prepare_for_handlers() return value

2014-01-07T15:23:24+00:00

Using an int with 0/1 is not very common, make the function return a bool instead with the same values (false/true). Signed-off-by: Johannes Berg

mac80211: simplify code in ieee80211_prepare_and_rx_handle

2014-01-07T15:22:15+00:00

No need to assign the return value of prepare_for_handlers to a variable if the only usage is to test it. Signed-off-by: Emmanuel Grumbach Signed-off-by: Johannes Berg

Merge remote-tracking branch 'wireless-next/master' into mac80211-next

2013-12-16T10:23:45+00:00

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless

2013-12-06T14:50:45+00:00

Conflicts: drivers/net/wireless/brcm80211/Kconfig net/mac80211/util.c

mac80211: neaten ieee80211_deliver_skb

2013-12-04T08:17:50+00:00

Remove the unnecessary duplicate test of "if (skb) {" when !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Remove now unnecessary __maybe_unused, neaten comment Remove unnecessary parenthesis around align cast. Substitute reference to deprecated compare_ether_addr with ether_addr_equal (in the comment.) Signed-off-by: Joe Perches [edit commit log slightly] Signed-off-by: Johannes Berg

mac80211: move align variable to remove __maybe_unused

2013-12-03T12:23:45+00:00

There's no reason for the variable to not be inside the #ifdef, move it. Signed-off-by: Johannes Berg

mac80211: use put_unaligned_le in mesh when necessary

2013-11-25T19:51:55+00:00

Use put_unaligned_le16 and put_unaligned_le32 for mesh_path_error_tx and mesh_path_sel_frame_tx. Signed-off-by: Chun-Yeow Yeoh Signed-off-by: Johannes Berg

mac80211: add generic cipher scheme support

2013-11-25T19:50:52+00:00

This adds generic cipher scheme support to mac80211, such schemes are fully under control by the driver. On hw registration drivers may specify additional HW ciphers with a scheme how these ciphers have to be handled by mac80211 TX/RR. A cipher scheme specifies a cipher suite value, a size of the security header to be added to or stripped from frames and how the PN is to be verified on RX. Signed-off-by: Max Stepanov Signed-off-by: Johannes Berg

mac80211: do not compute offset from ssn in Rx AMPDU reordering buffer

2013-11-25T19:49:36+00:00

Currently, frames that go into the reordering buffer are stored at index ieee80211_sn_sub(sn, tid_rx->ssn) % tid_rx->buf_size. The offset calculation to the starting sequence number (SSN) is useless and just adds overhead so simply use sn % tid_rx->buf_size. This means the reordering buffer will start to be filled somewhere in the middle (at SSN % buf_size) and continue to get used from there, but there's no reason to start from the beginning. Signed-off-by: Karl Beldan [rewrite commit message] Signed-off-by: Johannes Berg