lwn.git/net/bluetooth/l2cap.c, branch v2.6.23

[BLUETOOTH] l2cap: don't mangle cmd.len

2007-07-31T09:28:09+00:00

Since nobody uses it after we convert it to host-endian, no need to do that at all. At that point l2cap is endian-clean. Signed-off-by: Al Viro Signed-off-by: Marcel Holtmann Signed-off-by: David S. Miller

[BLUETOOTH]: pass (host-endian) cmd length as explicit argument to l2cap_conf_req()

2007-07-31T09:28:08+00:00

Signed-off-by: Al Viro Signed-off-by: Marcel Holtmann Signed-off-by: David S. Miller

[BLUETOOTH] l2cap: endianness annotations

2007-07-31T09:28:07+00:00

no code changes, just documenting existing types Signed-off-by: Al Viro Signed-off-by: Marcel Holtmann Signed-off-by: David S. Miller

[BLUETOOTH]: Fix endianness bug in l2cap_sock_listen()

2007-07-31T09:28:06+00:00

We loop through psm values, calling __l2cap_get_sock_by_addr(psm, ...) until we get NULL; then we set ->psm of our socket to htobs(psm). IOW, we find unused psm value and put it into our socket. So far, so good, but... __l2cap_get_sock_by_addr() compares its argument with ->psm of sockets. IOW, the entire thing works correctly only on little-endian. On big-endian we'll get "no socket with such psm" on the first iteration, since we won't find a socket with ->psm == 0x1001. We will happily conclude that 0x1001 is unused and slap htobs(0x1001) (i.e. 0x110) into ->psm of our socket. Of course, the next time around the same thing will repeat and we'll just get a fsckload of sockets with the same ->psm assigned. Fix: pass htobs(psm) to __l2cap_get_sock_by_addr() there. All other callers are already passing little-endian values and all places that store something in ->psm are storing little-endian. Signed-off-by: Al Viro Signed-off-by: Marcel Holtmann Signed-off-by: David S. Miller

[Bluetooth] Fix L2CAP configuration parameter handling

2007-05-24T12:27:19+00:00

The L2CAP configuration parameter handling was missing the support for rejecting unknown options. The capability to reject unknown options is mandatory since the Bluetooth 1.2 specification. This patch implements its and also simplifies the parameter parsing. Signed-off-by: Marcel Holtmann

[Bluetooth] Fix L2CAP and HCI setsockopt() information leaks

2007-05-04T22:35:59+00:00

The L2CAP and HCI setsockopt() implementations have a small information leak that makes it possible to leak kernel stack memory to userspace. If the optlen parameter is 0, no data will be copied by copy_from_user(), but the uninitialized stack buffer will be read and stored later. A call to getsockopt() can now retrieve the leaked information. To fix this problem the stack buffer given to copy_from_user() must be initialized with the current settings. Signed-off-by: Marcel Holtmann

[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}

2007-04-26T05:28:23+00:00

To clearly state the intent of copying from linear sk_buffs, _offset being a overly long variant but interesting for the sake of saving some bytes. Signed-off-by: Arnaldo Carvalho de Melo

[NET] BLUETOOTH: Use cpu_to_le{16,32}() where appropriate.

2007-04-26T05:23:54+00:00

Signed-off-by: YOSHIFUJI Hideaki Signed-off-by: David S. Miller

[NET] BLUETOOTH: Fix whitespace errors.

2007-02-11T07:19:20+00:00

Signed-off-by: YOSHIFUJI Hideaki Signed-off-by: David S. Miller

[Bluetooth] Restrict well known PSM to privileged users

2007-01-22T21:00:45+00:00

The PSM values below 0x1001 of L2CAP are reserved for well known services. Restrict the possibility to bind them to privileged users. Signed-off-by: Marcel Holtmann