lwn.git/fs/udf/inode.c, branch v3.17.5

udf: Fix loading of special inodes

2014-10-30T16:43:13+00:00

commit 6174c2eb8ecef271159bdcde460ce8af54d8f72f upstream. Some UDF media have special inodes (like VAT or metadata partition inodes) whose link_count is 0. Thus commit 4071b9136223 (udf: Properly detect stale inodes) broke loading these inodes because udf_iget() started returning -ESTALE for them. Since we still need to properly detect stale inodes queried by NFS, create two variants of udf_iget() - one which is used for looking up special inodes (which ignores link_count == 0) and one which is used for other cases which return ESTALE when link_count == 0. Fixes: 4071b913622316970d0e1919f7d82b4403fec5f2 Signed-off-by: Jan Kara Signed-off-by: Greg Kroah-Hartman

udf: Set i_generation field

2014-09-04T19:37:40+00:00

Currently UDF doesn't initialize i_generation in any way and thus NFS can easily get reallocated inodes from stale file handles. Luckily UDF already has a unique object identifier associated with each inode - i_unique. Use that for initialization of i_generation. Signed-off-by: Jan Kara

udf: Properly detect stale inodes

2014-09-04T19:37:39+00:00

NFS can easily ask for inodes that are already deleted. Currently UDF happily returns such inodes which is a bug. Return -ESTALE if udf_read_inode() is asked to read deleted inode. Signed-off-by: Jan Kara

udf: Make udf_read_inode() and udf_iget() return error

2014-09-04T19:36:35+00:00

Currently __udf_read_inode() wasn't returning anything and we found out whether we succeeded reading inode by checking whether inode is bad or not. udf_iget() returned NULL on failure and inode pointer otherwise. Make these two functions properly propagate errors up the call stack and use the return value in callers. Signed-off-by: Jan Kara

udf: Avoid infinite loop when processing indirect ICBs

2014-09-04T12:12:29+00:00

We did not implement any bound on number of indirect ICBs we follow when loading inode. Thus corrupted medium could cause kernel to go into an infinite loop, possibly causing a stack overflow. Fix the possible stack overflow by removing recursion from __udf_read_inode() and limit number of indirect ICBs we follow to avoid infinite loops. Signed-off-by: Jan Kara

udf: Fold udf_fill_inode() into __udf_read_inode()

2014-09-04T11:32:50+00:00

There's no good reason to separate these since udf_fill_inode() is called only from __udf_read_inode() and both do part of the same thing. Signed-off-by: Jan Kara

udf: Avoid dir link count to go negative

2014-09-04T09:47:51+00:00

If we are writing back inode of unlinked directory, its link count ends up being (u16)-1. Although the inode is deleted, udf_iget() can load the inode when NFS uses stale file handle and get confused. Signed-off-by: Jan Kara

switch {__,}blockdev_direct_IO() to iov_iter

2014-05-06T21:32:46+00:00

Signed-off-by: Al Viro

get rid of pointless iov_length() in ->direct_IO()

2014-05-06T21:32:45+00:00

all callers have iov_length(iter->iov, iter->nr_segs) == iov_iter_count(iter) Signed-off-by: Al Viro

pass iov_iter to ->direct_IO()

2014-05-06T21:32:44+00:00

unmodified, for now Signed-off-by: Al Viro