lwn.git/fs/ubifs/scan.c, branch v3.14.7

UBIFS: comply with coding style

2012-08-31T14:32:57+00:00

Join all the split printk lines in order to stop checkpatch complaining. Signed-off-by: Artem Bityutskiy

UBIFS: improve scanning debug output

2012-08-23T14:29:35+00:00

Include LEB number and offset in scanning debugging output. Signed-off-by: Artem Bityutskiy

UBIFS: always print full error reports

2012-08-22T14:41:44+00:00

Even when we are emulating power cuts, otherwise it is difficult to investigate failures during emulated power cuts testing. Signed-off-by: Artem Bityutskiy

UBIFS: get rid of dbg_err

2012-05-16T17:11:23+00:00

This patch removes the 'dbg_err()' macro and we now use 'ubifs_err()' instead. The idea of 'dbg_err()' was to compile out some error message to make the binary a bit smaller - but I think it was a bad idea. Signed-off-by: Artem Bityutskiy

UBIFS: rename dumping functions

2012-05-16T16:15:56+00:00

This commit re-names all functions which dump something from "dbg_dump_*()" to "ubifs_dump_*()". This is done for consistency with UBI and because this way it will be more logical once we remove the debugging sompilation option. Signed-off-by: Artem Bityutskiy

UBIFS: switch to ubifs_leb_read

2011-07-04T07:54:33+00:00

Instead of using 'ubi_read()' function directly, used the 'ubifs_leb_read()' helper function instead. This allows to get rid of several redundant error messages and make sure that we always have a stack dump on read errors. Signed-off-by: Artem Bityutskiy

UBIFS: introduce helper functions for debugging checks and tests

2011-07-04T07:54:28+00:00

This patch introduces helper functions for all debugging checks, so instead of doing if (!(ubifs_chk_flags & UBIFS_CHK_GEN)) we now do if (!dbg_is_chk_gen(c)) This is a preparation to further changes where the flags will go away, and we'll need to only change the helper functions, but the code which utilizes them won't be touched. At the same time this patch removes 'dbg_force_in_the_gaps()', 'dbg_force_in_the_gaps_enabled()', and dbg_failure_mode helpers for consistency. Signed-off-by: Artem Bityutskiy

UBIFS: remove double semicolon

2011-02-06T13:08:02+00:00

Just a tiny clean-up - remove ;; Signed-off-by: Artem Bityutskiy

UBIFS: mark unused key objects as invalid

2010-08-30T07:19:08+00:00

When scanning the flash, UBIFS builds a list of flash nodes of type 'struct ubifs_scan_node'. Each scanned node has a 'snod->key' field. This field is valid for most of the nodes, but invalid for some node type, e.g., truncation nodes. It is safer to explicitly initialize such keys to something invalid, rather than leaving them initialized to all zeros, which has key type of UBIFS_INO_KEY. This patch introduces new "fake" key type UBIFS_INVALID_KEY and initializes unused 'snod->key' objects to this type. It also adds debugging assertions in the TNC code to make sure no one ever tries to look these nodes up in the TNC. Signed-off-by: Artem Bityutskiy

UBIFS: do not write rubbish into truncation scanning node

2010-08-30T07:19:08+00:00

In the scanning code, in 'ubifs_add_snod()', we write rubbish into 'snod->key', because we assume that on-flash truncation nodes have a key, but they do not. If the other parts of UBIFS then mistakenly try to look-up the truncation node key (they should not do this, but may do because of a bug), we can succeed and corrupt TNC. It looks like we did have such a situation in 'sort_nodes()' in gc.c. Signed-off-by: Artem Bityutskiy