lwn.git/fs/nfs/delegation.c, branch docs-5.6

NFSv4: Handle NFS4ERR_OLD_STATEID in delegreturn

2019-11-04T02:28:46+00:00

If the server returns NFS4ERR_OLD_STATEID in response to our delegreturn, we want to sync to the most recent seqid for the delegation stateid. However if we are already at the most recent, we have two possibilities: - an OPEN reply is still outstanding and will return a new seqid - an earlier OPEN reply was dropped on the floor due to a timeout. In the latter case, we may end up unable to complete the delegreturn, so we want to bump the seqid to a value greater than the cached value. While this may cause us to lose the delegation in the former case, it should now be safe to assume that the client will replay the OPEN if necessary in order to get a new valid stateid. Signed-off-by: Trond Myklebust

NFSv4: Fix races between open and delegreturn

2019-11-04T02:28:46+00:00

If the server returns the same delegation in an open that we just used in a delegreturn, we need to ensure we don't apply that stateid if the delegreturn has freed it on the server. To do so, we ensure that we do not free the storage for the delegation until either it is replaced by a new one, or we throw the inode out of cache. Signed-off-by: Trond Myklebust

NFS: nfs_inode_find_state_and_recover() fix stateid matching

2019-11-04T02:28:46+00:00

In nfs_inode_find_state_and_recover() we want to mark for recovery only those stateids that match or are older than the supplied stateid parameter. Signed-off-by: Trond Myklebust

NFSv4: Fix nfs4_inode_make_writeable()

2019-11-04T02:28:46+00:00

Fix the checks in nfs4_inode_make_writeable() to ignore the case where we hold no delegations. Currently, in such a case, we automatically flush writes. Signed-off-by: Trond Myklebust

NFSv4: Don't reclaim delegations that have been returned or revoked

2019-11-04T02:28:46+00:00

If the delegation has already been revoked, we want to avoid reclaiming it on reboot. Signed-off-by: Trond Myklebust

NFSv4: Ignore requests to return the delegation if it was revoked

2019-11-04T02:28:46+00:00

If the delegation was revoked, or is already being returned, just clear the NFS_DELEGATION_RETURN and NFS_DELEGATION_RETURN_IF_CLOSED flags and keep going. Signed-off-by: Trond Myklebust

NFSv4: Revoke the delegation on success in nfs4_delegreturn_done()

2019-11-04T02:28:46+00:00

If the delegation was successfully returned, then mark it as revoked. Signed-off-by: Trond Myklebust

NFSv4: Update the stateid seqid in nfs_revoke_delegation()

2019-11-04T02:28:46+00:00

If we revoke a delegation, but the stateid's seqid is newer, then ensure we update the seqid when marking the delegation as revoked. Signed-off-by: Trond Myklebust

NFSv4: Clear the NFS_DELEGATION_REVOKED flag in nfs_update_inplace_delegation()

2019-11-04T02:28:45+00:00

If the server sent us a new delegation stateid that is more recent than the one that got revoked, then clear the NFS_DELEGATION_REVOKED flag. Signed-off-by: Trond Myklebust

NFSv4: Hold the delegation spinlock when updating the seqid

2019-11-04T02:28:45+00:00

Signed-off-by: Trond Myklebust