lwn.git/fs/ext4/mballoc.h, branch v4.5.3

ext4: remove unused ac_ex_scanned

2014-02-20T18:32:10+00:00

When looking at a bug report with: > kernel: EXT4-fs: 0 scanned, 0 found I thought wow, 0 scanned, that's odd? But it's not odd; it's printing a variable that is initialized to 0 and never touched again. It's never been used since the original merge, so I don't really even know what the original intent was, either. If anyone knows how to hook it up, speak now via patch, otherwise just yank it so it's not making a confusing situation more confusing in kernel logs. Signed-off-by: Eric Sandeen Signed-off-by: "Theodore Ts'o"

ext4: address a benign compiler warning

2014-02-18T01:50:59+00:00

When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as a no_printk() statement instead of an empty statement in order to suppress the following compiler warning: fs/ext4/mballoc.c: In function ‘ext4_mb_cleanup_pa’: fs/ext4/mballoc.c:2659:47: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] mb_debug(1, "mballoc: %u PAs left\n", count); Signed-off-by: Patrick Palka Signed-off-by: "Theodore Ts'o"

ext4: use module parameters instead of debugfs for mballoc_debug

2013-02-09T21:28:20+00:00

There are multiple reasons to move away from debugfs. First of all, we are only using it for a single parameter, and it is much more complicated to set up (some 30 lines of code compared to 3), and one more thing that might fail while loading the ext4 module. Secondly, as a module paramter it can be specified as a boot option if ext4 is built into the kernel, or as a parameter when the module is loaded, and it can also be manipulated dynamically under /sys/module/ext4/parameters/mballoc_debug. So it is more flexible. Ultimately we want to move away from using mb_debug() towards tracepoints, but for now this is still a useful simplification of the code base. Signed-off-by: "Theodore Ts'o"

ext4: remove unused macro MB_DEFAULT_MAX_GROUPS_TO_SCAN

2012-08-17T14:00:17+00:00

Signed-off-by: Robin Dong Signed-off-by: "Theodore Ts'o"

ext4: remove EXT4_MB_{BITMAP,BUDDY} macros

2012-02-20T22:54:06+00:00

The EXT4_MB_BITMAP and EXT4_MB_BUDDY macros obfuscate more than they provide any abstraction. So remove them. Signed-off-by: "Theodore Ts'o"

ext4: expand commit callback and

2012-02-20T22:53:02+00:00

The per-commit callback was used by mballoc code to manage free space bitmaps after deleted blocks have been released. This patch expands it to support multiple different callbacks, to allow other things to be done after the commit has been completed. Signed-off-by: Bobi Jam Signed-off-by: Andreas Dilger Signed-off-by: "Theodore Ts'o"

ext4: fix a typo in struct ext4_allocation_context

2011-10-31T22:55:50+00:00

This patch changes "bext" to "best". Signed-off-by: Robin Dong Signed-off-by: "Theodore Ts'o"

ext4: teach ext4_free_blocks() about bigalloc and clusters

2011-09-09T22:50:51+00:00

The ext4_free_blocks() function now has two new flags that indicate whether a partial cluster at the beginning or the end of the block extents should be freed or not. That will be up the caller (i.e., truncate), who can figure out whether partial clusters at the beginning or the end of a block range can be freed. We also have to update the ext4_mb_free_metadata() and release_blocks_on_commit() machinery to be cluster-based, since it is used by ext4_free_blocks(). Signed-off-by: "Theodore Ts'o"

ext4: teach mballoc preallocation code about bigalloc clusters

2011-09-09T22:48:51+00:00

In most of mballoc.c, we do everything in units of clusters, since the block allocation bitmaps and buddy bitmaps are all denominated in clusters. The one place where we do deal with absolute block numbers is in the code that handles the preallocation regions, since in the case of inode-based preallocation regions, the start of the preallocation region can't be relative to the beginning of the group. So this adds a bit of complexity, where pa_pstart and pa_lstart are block numbers, while pa_free, pa_len, and fe_len are denominated in units of clusters. Signed-off-by: "Theodore Ts'o"

ext4: convert block group-relative offsets to use clusters

2011-09-09T22:46:51+00:00

Certain parts of the ext4 code base, primarily in mballoc.c, use a block group number and offset from the beginning of the block group. This offset is invariably used to index into the allocation bitmap, so change the offset to be denominated in units of clusters. Signed-off-by: "Theodore Ts'o"