lwn.git/fs/cifs/link.c, branch docs-5.3

SMB3: Clean up query symlink when reparse point

2019-05-08T04:24:55+00:00

Two of the common symlink formats use reparse points (unlike mfsymlinks and also unlike the SMB1 posix extensions). This is the first part of the fixes to allow these reparse points (NFS style and Windows symlinks) to be resolved properly as symlinks by the client. Signed-off-by: Ronnie Sahlberg Signed-off-by: Steve French

cifs: replace snprintf with scnprintf

2019-03-05T02:05:34+00:00

a trivial patch that replaces all use of snprintf with scnprintf. scnprintf() is generally seen as a safer function to use than snprintf for many use cases. In our case, there is no actual difference between the two since we never look at the return value. Thus we did not have any of the bugs that scnprintf protects against and the patch does nothing. However, for people reading our code it will be a receipt that we have done our due dilligence and checked our code for this type of bugs. See the presentation "Making C Less Dangerous In The Linux Kernel" at this years LCA Signed-off-by: Ronnie Sahlberg Signed-off-by: Steve French

smb3: don't request leases in symlink creation and query

2018-08-07T19:15:57+00:00

Fixes problem pointed out by Pavel in discussions about commit 729c0c9dd55204f0c9a823ac8a7bfa83d36c7e78 Signed-off-by: Pavel Shilovsky Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg CC: Stable # 3.18.x+

cifs: fix a buffer leak in smb2_query_symlink

2018-06-08T04:39:41+00:00

This leak was introduced in 91cb74f5142c14dd921ab2d064b7b128054f9fae and caused us to leak one small buffer for every symlink query. Signed-off-by: Ronnie Sahlberg Signed-off-by: Steve French

CIFS: refactor crypto shash/sdesc allocation&free

2018-04-02T01:24:39+00:00

shash and sdesc and always allocated and freed together. * abstract this in new functions cifs_alloc_hash() and cifs_free_hash(). * make smb2/3 crypto allocation independent from each other. Signed-off-by: Aurelien Aptel Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg CC: Stable

[SMB3] Remove ifdef since SMB3 (and later) now STRONGLY preferred

2017-07-08T23:57:07+00:00

Remove the CONFIG_CIFS_SMB2 ifdef and Kconfig option since they must always be on now. For various security reasons, SMB3 and later are STRONGLY preferred over CIFS and older dialects, and SMB3 (and later) will now be the default dialects so we do not want to allow them to be ifdeffed out. In the longer term, we may be able to make older CIFS support disableable in Kconfig with a new set of #ifdef, but we always want SMB3 and later support enabled. Signed-off-by: Steven French Reviewed-by: Pavel Shilovsky

cifs: use %16phN for formatting md5 sum

2016-12-15T06:21:37+00:00

Passing a gazillion arguments takes a lot of code: add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-253 (-253) Signed-off-by: Rasmus Villemoes Reviewed-by: Pavel Shilovsky Signed-off-by: Steve French

cifs: get rid of unused arguments of CIFSSMBWrite()

2016-09-28T01:54:53+00:00

they used to be used, but... Signed-off-by: Al Viro

switch ->get_link() to delayed_call, kill ->put_link()

2015-12-30T18:01:03+00:00

Signed-off-by: Al Viro

replace ->follow_link() with new method that could stay in RCU mode

2015-12-09T03:41:54+00:00

new method: ->get_link(); replacement of ->follow_link(). The differences are: * inode and dentry are passed separately * might be called both in RCU and non-RCU mode; the former is indicated by passing it a NULL dentry. * when called that way it isn't allowed to block and should return ERR_PTR(-ECHILD) if it needs to be called in non-RCU mode. It's a flagday change - the old method is gone, all in-tree instances converted. Conversion isn't hard; said that, so far very few instances do not immediately bail out when called in RCU mode. That'll change in the next commits. Signed-off-by: Al Viro