lwn.git/drivers/usb/serial/usb-serial.c, branch v4.12

USB: serial: drop obsolete open-race workaround

2017-03-31T11:14:39+00:00

Commit a65a6f14dc24 ("USB: serial: fix race between probe and open") fixed a race between probe and open, which could lead to crashes when a not yet fully initialised port was being opened. This race was later incidentally closed by commit 7e73eca6a7b2 ("TTY: move cdev_add to tty_register_device") which moved character-device registration from tty_register_driver to tty_register_device, which isn't called until the port has been fully set up. Remove the now redundant workaround which had the negative side effect of not allowing a port to be opened immediately after user space had been notified of a new tty device. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: move pl2303 hack out of usb-serial core

2017-03-28T08:59:01+00:00

Some pl2303 devices require the use of the interrupt endpoint of an unrelated interface. This has so far been dealt with in usb-serial core, but can now be moved to a driver calc_num_ports callback. Note that we relax the endpoint requirements checked by core and instead verify that we have an interrupt-in endpoint in calc_num_ports for all devices so that the hack can first be applied. Signed-off-by: Johan Hovold

USB: serial: add calc_num_ports callback to generic driver

2017-03-28T08:54:39+00:00

Add a calc_num_ports callback to the generic driver and verify that the device has the required endpoints there instead of in core. Note that the generic driver num_ports field was never used. Signed-off-by: Johan Hovold

USB: serial: add probe callback to generic driver

2017-03-28T08:54:39+00:00

Add a probe callback to the generic driver and print the only-for-testing message there. This is a first step in getting rid of the CONFIG_USB_SERIAL_GENERIC ifdef from usb-serial core. Signed-off-by: Johan Hovold

USB: serial: allow subdrivers to modify port-endpoint mapping

2017-03-28T08:54:39+00:00

Allow subdrivers to modify the port-endpoint mapping by passing the endpoint descriptors to calc_num_ports. The callback can now also be used to verify that the required endpoints exists and abort probing otherwise. This will allow us to get rid of a few hacks in subdrivers that are already modifying the port-endpoint mapping (or aborting probe due to missing endpoints), but only after the port structures have been setup. Signed-off-by: Johan Hovold

USB: serial: add endpoint sanity check to core

2017-03-16T09:33:41+00:00

Allow drivers to specify a minimum number of endpoints per type, which USB serial core will verify after subdriver probe has returned (where the current alternate setting may have been changed). Signed-off-by: Johan Hovold

USB: serial: replace runtime overflow check

2017-03-16T09:33:41+00:00

Since commit 0a8fd1346254 ("USB: fix problems with duplicate endpoint addresses") USB core guarantees that there are no more than 15 endpoint descriptors per type (and altsetting) so the corresponding overflow checks can now be replaced with a compile-time check on the array sizes (and indirectly the maximum number of ports). Signed-off-by: Johan Hovold

USB: serial: refactor and clean up endpoint handling

2017-03-16T09:33:09+00:00

Refactor and clean up endpoint handling. This specifically moves the endpoint-descriptor arrays of the stack. Note that an err_free_epds label is not yet added to avoid a compilation warning when neither CONFIG_USB_SERIAL_PL2303 or CONFIG_USB_SERIAL_GENERIC is selected. Signed-off-by: Johan Hovold

USB: serial: clean up endpoint and port-counter types

2017-03-16T09:13:37+00:00

Use unsigned-char type for the endpoint and port counters. Signed-off-by: Johan Hovold

USB: serial: clean up probe error paths

2017-03-16T09:13:36+00:00

Clean up the probe error paths by adding a couple of new error labels. Signed-off-by: Johan Hovold