lwn.git/drivers/spi/spi-pic32-sqi.c, branch v4.20-rc2

spi: pic32-sqi: don't pass GFP_DMA32 to dma_alloc_coherent

2018-10-17T10:11:32+00:00

The DMA API does its own zone decisions based on the coherent_dma_mask. Signed-off-by: Christoph Hellwig Signed-off-by: Mark Brown

spi: pic32-sqi: remove unnecessary of_node_get()

2018-09-17T17:54:08+00:00

Almost all spi drivers assign spi master->dev.of_node from its parent platform device without additional refcounting. It seems of_node_get() in pic32_sqi_probe() is unnecessary and there is no corresponding of_node_put(). Found by Linux Driver Verification project (linuxtesting.org) Signed-off-by: Alexey Khoroshilov Signed-off-by: Mark Brown

spi: pic32-sqi: use list_move_tail and list_move

2016-08-08T10:56:40+00:00

Using list_move_tail() and list_move() to simplify the code. Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown

spi: pic32-sqi: fixup wait_for_completion_timeout return handling

2016-07-24T20:49:57+00:00

wait_for_completion_timeout returns unsigned long not int so the check for <= 0 should be == 0 here, and the type unsigned long. The function return is set to -ETIMEDOUT to reflect the actual problem. Signed-off-by: Nicholas Mc Guire Signed-off-by: Mark Brown

spi: pic32-sqi: Remove pic32_sqi_setup and pic32_sqi_cleanup

2016-05-06T17:18:27+00:00

Current code does not use ctldata at all, so remove spi_set_ctldata call. spi_setup() will set spi->bits_per_word = 8 if it was not set, so remove !spi->max_speed_hz checking. The spi core allows absent of spi->max_speed_hz setting, if it was not set spi_setup() assigns spi->master->max_speed_hz to it. spi core allows spi->max_speed_hz > spi->master->max_speed_hz, in this case spi core will limit the transfer speed to ensure xfer->speed_hz won't greater than spi->master->max_speed_hz so remove checking if spi->max_speed_hz is higher than spi->master->max_speed_hz. As a result, both pic32_sqi_setup() and pic32_sqi_cleanup() can be removed. Signed-off-by: Axel Lin Signed-off-by: Mark Brown

spi: pic32-sqi: silence array overflow warning

2016-04-22T15:25:41+00:00

We read one element beyond the end of the array when we access "rdesc[i + 1]" so it causes a static checker warning. It's harmless because we write over it again on the next line. But let's just silence the warning. Signed-off-by: Dan Carpenter Reviewed-by: Purna Chandra Mandal Signed-off-by: Mark Brown

spi: pic32-sqi: add SPI driver for PIC32 SQI controller.

2016-04-18T16:52:46+00:00

This driver implements SPI master interface for Quad SPI controller, specifically for accessing quad SPI flash. It uses descriptor-based DMA transfer mode and supports half-duplex communication for single, dual and quad SPI transactions. Signed-off-by: Purna Chandra Mandal Cc: Mark Brown Signed-off-by: Mark Brown