lwn.git/drivers/slimbus/qcom-ngd-ctrl.c, branch docs-5.8-2

slimbus: ngd: add v2.1.0 compatible

2020-03-12T15:51:15+00:00

This patch adds compatible for SlimBus Controller on SDM845. Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20200312152510.12224-1-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: qcom-ngd-ctrl: Use dma_request_chan() instead dma_request_slave_channel()

2020-01-14T20:46:47+00:00

dma_request_slave_channel() is a wrapper on top of dma_request_chan() eating up the error code. By using dma_request_chan() directly the driver can support deferred probing against DMA. Signed-off-by: Peter Ujfalusi Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20200109103148.5612-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: qcom-ngd-ctrl: Add of_node_put() before return

2019-08-18T10:56:10+00:00

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Reviewed-by: Bjorn Andersson Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20190818093902.29993-2-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman

slimbus: fix a potential NULL pointer dereference in of_qcom_slim_ngd_register

2019-04-25T20:23:06+00:00

In case platform_device_alloc fails, the fix returns an error code to avoid the NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: ngd: fix spelling mistake "exeeds" -> "exceeds"

2018-12-06T14:50:06+00:00

There is a spelling mistake in a dev_err message, fix this. Signed-off-by: Colin Ian King Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: ngd: Fix build error on x86

2018-11-27T07:44:06+00:00

on non DT platforms like x86 of_match_node is set to NULL, dereferencing directly would throw an error. Fix this by doing this in two steps, get the match then the data. Reported-by: Greg KH Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: ngd: remove unnecessary check

2018-11-07T13:59:28+00:00

SLIM_MSG_CLK_PAUSE_SEQ_FLG is never set in any of the slim core, so performing a check in ngd driver is totally unnecessary. Also this patch fixes warning about mc field overflow reported with CoverityScan. Making clk pause feature optional will be added to slim core in next development cycle. Reported-by: Colin Ian King Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: ngd: validate logical address assigned by remote

2018-09-25T18:21:02+00:00

Validate logical address assigned by remote, in failure cases this value is all zeors. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

silmbus: ngd: register controller after power up.

2018-09-25T18:21:02+00:00

Register slimbus controller only after finishing powerup sequnce so that we do not endup in situation where core starts sending transactions before the controller is ready. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman

slimbus: ngd: return proper error code instead of zero

2018-09-25T18:21:02+00:00

It looks like there is a typo in probe return. Fix it. Signed-off-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman