lwn.git/drivers/pcmcia, branch docs-5.8-2

pcmcia: remove some unused space characters

2020-03-31T16:48:22+00:00

There are a few space characters I found by chance. I think they are redundant, so I removed them. Signed-off-by: Hu Haowen Signed-off-by: Dominik Brodowski

pcmcia: soc_common.h: Replace zero-length array with flexible-array member

2020-03-28T06:52:13+00:00

The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Dominik Brodowski

pcmcia: cs_internal.h: Replace zero-length array with flexible-array member

2020-03-28T06:52:09+00:00

pcmcia: Use scnprintf() for avoiding potential buffer overflow

2020-03-14T13:32:04+00:00

Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by: Takashi Iwai Signed-off-by: Dominik Brodowski

pcmcia: omap: remove useless cast for driver.name

2020-03-14T13:32:02+00:00

device_driver name is const char pointer, so it not useful to cast driver_name (which is already const char). Signed-off-by: Corentin Labbe Signed-off-by: Dominik Brodowski

PCMCIA/i82092: remove #if 0 block

2019-12-16T10:49:54+00:00

Remove the unused function indirect_read16, which is similar to indirect_read with the exception that it reads 16 instead of 8 bit. Co-developed-by: Lukas Panzer Signed-off-by: Lukas Panzer Signed-off-by: Simon Geis Signed-off-by: Dominik Brodowski

PCMCIA/i82092: delete enter/leave macro

2019-12-16T10:49:54+00:00

Remove the enter/leave macros and the corresponding calls. These are obsolete since ftrace is available. Co-developed-by: Lukas Panzer Signed-off-by: Lukas Panzer Signed-off-by: Simon Geis Signed-off-by: Dominik Brodowski

PCMCIA/i82092: include instead of

2019-12-16T10:49:53+00:00

Include the more general linux/io.h instead of asm/io.h as checkpatch suggests. Co-developed-by: Lukas Panzer Signed-off-by: Lukas Panzer Signed-off-by: Simon Geis Signed-off-by: Dominik Brodowski

PCMCIA/i82092: shorten the lines with over 80 characters

2019-12-16T10:49:53+00:00

Split the lines with more than 80 characters in order to improve readability of the code. Co-developed-by: Lukas Panzer Signed-off-by: Lukas Panzer Signed-off-by: Simon Geis Signed-off-by: Dominik Brodowski

PCMCIA/i82092: move assignment out of if condition

2019-12-16T10:49:53+00:00

Improve readability by moving the assignment out of if conditions. Co-developed-by: Lukas Panzer Signed-off-by: Lukas Panzer Signed-off-by: Simon Geis Signed-off-by: Dominik Brodowski