lwn.git/drivers/net/wireless/ath/ath5k/phy.c, branch v3.15.7

ath5k: shifting the wrong variable for AR5K_AR5210

2014-02-13T19:58:12+00:00

In the original code we shift "AR5K_PHY(256) >> 28" which is zero but the intent was to shift the return value of ath5k_hw_reg_read() like we do a couple lines later. Signed-off-by: Dan Carpenter Signed-off-by: John W. Linville

ath5k: cleanup channel to eprom_mode function

2013-03-06T21:24:27+00:00

Stop returning negative values from ath5k_eeprom_mode_from_channel. Yell loudly about that case in that function instead and return the default/zero/mode A. This cleans up the callers, but needs to pass ah down to ath5k_eeprom_mode_from_channel for ATH5K_WARN. For that purpose we also need the declaration to be moved to ath5k.h. Signed-off-by: Jiri Slaby Acked-by: Nick Kossifidis Signed-off-by: John W. Linville

NET: ath5k, check ath5k_eeprom_mode_from_channel retval

2013-02-08T19:51:35+00:00

It can, if invalid argument given, return a negative value. In that case we would access arrays out-of-bounds and such. Check the value and yell loudly if that happened as it would be a bug in the implementation. (Instead of silently corrupting memory.) Signed-off-by: Jiri Slaby Cc: Nick Kossifidis Cc: "Luis R. Rodriguez" Signed-off-by: John W. Linville

ath5k: add missing breaks in ath5k_hw_set_spur_mitigation_filter

2012-09-25T19:57:44+00:00

https://bugzilla.kernel.org/show_bug.cgi?id=47681 Reported-by: David Binderman Signed-off-by: John W. Linville

ath5k: Put power_level where it belongs and rename it

2012-08-10T19:26:57+00:00

Put power_level to ah_txpower struct with the rest tx power infos and also rename it to txp_requested to make more sense. v2 make sure we don't memset it to zero on reset Signed-off-by: Nick Kossifidis Signed-off-by: John W. Linville

ath5k: Preserve tx power level requested from above on phy_init

2012-08-10T19:26:56+00:00

By using cur_pwr on phy_init we re-use the power level previously set by the driver, not the one we got from above. Signed-off-by: Nick Kossifidis Signed-off-by: John W. Linville

ath5k: Fix range scaling when setting rate power table

2012-08-10T19:26:55+00:00

rates[i] is unsigned but txp_offset can be negative for newer parts with PDADC table. We cover the case when rates[i] + txp_offset > 63 but we must also cover the case when its < 0 or else rates[i] will overflow. Signed-off-by: Nick Kossifidis Signed-off-by: John W. Linville

ath5k: Use correct value for min_pwr and cur_pwr

2012-08-10T19:26:55+00:00

Make sure we don't store the table offsets for min and cur power levels, store the 0.25dB values instead. This way we don't clamp the tx power level to max (because now cur_pwr holds the 0.25dB value, not the table offset) after re-using cur_pwr on reset. Signed-off-by: Nick Kossifidis Signed-off-by: John W. Linville

ath: Add and use pr_fmt, convert printks to pr_

2012-04-10T18:52:13+00:00

Use a more current logging style. Make sure all output is prefixed appropriately. Signed-off-by: Joe Perches Signed-off-by: John W. Linville

ath5k: do not re-run AGC calibration periodically

2012-03-06T20:16:18+00:00

All other Atheros drivers run the AGC gain calibration and DC offset calibration only after reset. Running them periodically has caused stability issues on some (primarily AR2315/2413/5413/5414 based) devices, leading to messages such as: ath5k phy0: gain calibration timeout (2462MHz) ath5k phy0: calibration of channel 11 failed Related bug reports: https://dev.openwrt.org/ticket/10574 https://bugzilla.redhat.com/show_bug.cgi?id=795141 Signed-off-by: Felix Fietkau Acked-by: Nick Kossifidis Signed-off-by: John W. Linville