lwn.git/drivers/infiniband/hw/nes/nes_verbs.c, branch v5.17-rc2

rdma: Remove nes

2019-06-13T13:59:49+00:00

This driver was first merged over 10 years ago and has not seen major activity by the authors in the last 7 years. However, in that time it has been patched 150 times to adapt it to changing kernel APIs. Further, the hardware has several issues, like not supporting 64 bit DMA, that make it rather uninteresting for use with modern systems and RDMA. Signed-off-by: Jason Gunthorpe Reviewed-by: Leon Romanovsky Reviewed-by: Shiraz Saleem Signed-off-by: Doug Ledford

RDMA: Convert CQ allocations to be under core responsibility

2019-06-11T20:39:49+00:00

Ensure that CQ is allocated and freed by IB/core and not by drivers. Signed-off-by: Leon Romanovsky Acked-by: Gal Pressman Reviewed-by: Dennis Dalessandro Tested-by: Dennis Dalessandro Signed-off-by: Doug Ledford

RDMA: Clean destroy CQ in drivers do not return errors

2019-06-11T20:17:10+00:00

Like all other destroy commands, .destroy_cq() call is not supposed to fail. In all flows, the attempt to return earlier caused to memory leaks. This patch converts .destroy_cq() to do not return any errors. Signed-off-by: Leon Romanovsky Acked-by: Gal Pressman Acked-by: Dennis Dalessandro Signed-off-by: Doug Ledford

RDMA/nes: Avoid memory allocation during CQ destroy

2019-06-11T20:12:34+00:00

The memory allocation call can fail and cause to early return from nes_desotroy_cq() function. This situation will cause to memory leak of struct nes_cq. Rewrite function to avoid memory allocation. Signed-off-by: Leon Romanovsky Signed-off-by: Doug Ledford

RDMA: Move owner into struct ib_device_ops

2019-06-10T19:56:03+00:00

This more closely follows how other subsytems work, with owner being a member of the structure containing the function pointers. Signed-off-by: Jason Gunthorpe Reviewed-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe

RDMA: Move uverbs_abi_ver into struct ib_device_ops

2019-06-10T19:56:02+00:00

No reason for every driver to emit code to set this, just make it part of the driver's existing static const ops structure. Signed-off-by: Jason Gunthorpe Reviewed-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe

RDMA: Move driver_id into struct ib_device_ops

2019-06-10T19:56:02+00:00

RDMA/nes: Remove useless NULL checks

2019-05-21T18:50:53+00:00

The destroy functions are always called with relevant structs, there is no need to check their existence. Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe

RDMA/umem: Move page_shift from ib_umem to ib_odp_umem

2019-05-21T18:23:24+00:00

This value has always been set to PAGE_SHIFT in the core code, the only thing that does differently was the ODP path. Move the value into the ODP struct and still use it for ODP, but change all the non-ODP things to just use PAGE_SHIFT/PAGE_SIZE/PAGE_MASK directly. Reviewed-by: Shiraz Saleem Signed-off-by: Jason Gunthorpe Signed-off-by: Leon Romanovsky

RDMA: Get rid of iw_cm_verbs

2019-05-03T13:56:56+00:00

Integrate iw_cm_verbs data members into ib_device_ops and ib_device structs, this is done to achieve the following: 1) Avoid memory related bugs durring error unwind 2) Make the code more cleaner 3) Reduce code duplication Signed-off-by: Kamal Heib Signed-off-by: Jason Gunthorpe