lwn.git/drivers/hid/hid-thingm.c, branch docs-fixes

HID: remove ThingM blink(1) driver

2016-06-23T06:48:42+00:00

Now that support for ThingM blink(1) was merged into the hid-led driver the dedicated driver for this device can be removed. Signed-off-by: Heiner Kallweit Acked-by: Vivien Didelot Signed-off-by: Jiri Kosina

HID: thingm: remove not needed error message

2016-04-25T09:30:57+00:00

LED core takes care of handling failed calls to thingm_let_set. - print error message in set_brightness_delayed or - pass error to caller in led_set_brightness_sync Also the error message here doesn't provide any hint what actually went wrong. Therefore remove it. Signed-off-by: Heiner Kallweit Reviewed-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: thingm: set new flag LED_HW_PLUGGABLE

2016-04-18T11:01:38+00:00

Use recently introduced flag LED_HW_PLUGGABLE to avoid warnings when the device is unplugged. Signed-off-by: Heiner Kallweit Reviewed-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

HID: thingm: factor out duplicated code to thingm_init_led

2016-04-18T11:01:38+00:00

Simplify thingm_init_rgb by factoring out duplicated code to thingm_init_led. Signed-off-by: Heiner Kallweit Reviewed-by: Benjamin Tissoires Signed-off-by: Jiri Kosina

hid: thingm: reorder calls in thingm_probe

2016-03-15T14:28:55+00:00

When reviewing another thingm patch Benjamin Tissoires pointed out the following: "The problem here is that hid_hw_start() is called before thingm_version() which allows user space to briefly introduce races between thingm_version() and any hidraw requests. The mutex will not help here as it is initialized after hid_hw_start() and only used for protecting the concurrent access of the rgb." Avoid this possible issue by calling hid_hw_start() later in the probe function. Signed-off-by: Heiner Kallweit Signed-off-by: Jiri Kosina

HID: thingm: improve locking

2016-03-02T09:20:31+00:00

Reading from the device consists of two operations: sending the read command and the actual read from the device. If the device is accessed in between we might read wrong data. Therefore protect the full sequence of both operations with a mutex. Also change the semantics of thingm_recv to include both operations. Signed-off-by: Heiner Kallweit Signed-off-by: Jiri Kosina

HID: thingm: switch to managed version of led_classdev_register

2016-03-02T09:20:30+00:00

Simplify the code by switching to the managed version of led_classdev_register. Signed-off-by: Heiner Kallweit Signed-off-by: Jiri Kosina

HID: thingm: remove workqueue

2016-03-02T09:20:30+00:00

Defining workqueues in LED drivers isn't needed any longer as the LED core was extended with a generic workqueue recently. Signed-off-by: Heiner Kallweit Signed-off-by: Jiri Kosina

Merge branches 'for-3.18/always-poll-quirk', 'for-3.18/logitech', 'for-3.18/picolcd', 'for-3.18/rmi', 'for-3.18/sony', 'for-3.18/uhid', 'for-3.18/upstream' and 'for-3.18/wacom' into for-linus

2014-10-06T21:34:40+00:00

HID: thingm: fix workqueue race on remove

2014-09-04T06:56:06+00:00

thingm_remove_rgb() needs to flush the workqueue after all the LED classes have been unregistered, otherwise the removal might race with another LED event coming, causing thingm_led_set() to schedule additional work after thingm_remove_rgb() has flushed it. This obviously causes oops later, as the scheduled work has been freed in the meantime. In addition to that, move the hid_hw_stop() to an earlier place, so that dmesg is not polluted by failure messages about not being able to write the LED while the device is being shut down. Reported-and-tested-by: Dylan Alex Simon Signed-off-by: Jiri Kosina