lwn.git/drivers/gpu/drm/omapdrm/omap_fb.c, branch docs-4.16

drm/omap: fix memory leak when FB init fails

2017-08-15T12:18:25+00:00

omap_framebuffer_create() fails to unref all the gem objects if creating the FB fails, leading to a memory leak. Fix the loop so that it goes through all the reffed gem objects. Signed-off-by: Tomi Valkeinen

drm/omap: fix YUV422 rotation with TILER

2017-06-02T08:08:59+00:00

TILER rotation with YUV422 pixelformats does not work at the moment. All other pixel formats work, because the pixelformat's pixel size is equal to tiler unit size (e.g. XR24's pixel size is 32 bits, and the TILER unit size that has to be used is 32 bits). For YUV422 formats this is not the case, as the TILER unit size has to be 32 bits, but the pixel size is 16 bits. The end result is OCP errors and sync losts. This patch adds the code to adjust the variables for YUV422 formats. We could make the code more generic by passing around the pixel format, rotation type, angle and the tiler unit size, which would allow us to do calculations without special case for YUV422. However, this would make the code more complex, and at least for now this is much more easier to handle with these two special cases for YUV422. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: pass rotation to dispc

2017-06-02T08:08:15+00:00

The omapdrm driver has not passed the rotation value to the dispc driver. This doesn't affect RGB formats, but YUV formats don't work without dispc knowing the orientation. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: remove omap_drm_win

2017-06-02T08:04:17+00:00

struct omap_drm_window is only used to pass plane setup data to omap_framebuffer_update_scanout(). This can as well be accomplished by just passing the DRM state. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: add drm_rotation_to_tiler helper()

2017-06-02T08:04:07+00:00

Add a helper function to convert DRM rotation to TILER rotation. Also drop a error print that can never happen, as the DRM framework makes sure the rotation is valid. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: rename color_mode to fourcc

2017-06-02T07:57:26+00:00

Now that we use fourccs, we can also rename the 'color_mode' variables to 'fourcc'. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: cleanup formats array

2017-06-02T07:57:25+00:00

omap_fb.c has a table with DSS and DRM formats, used to convert between them. This is no longer needed, so we can change the array to a plain array of DRM_FORMAT_* values which contain all possible pixel formats supported by any DSS IP version. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: remove omap_framebuffer_get_formats()

2017-06-02T07:57:25+00:00

We now get a fourcc array from dispc when asking for a plane's supported pixel formats, so we can drop omap_framebuffer_get_formats() which was used to convert between DSS and DRM pixel formats. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: use DRM_FORMAT_* instead of OMAP_DSS_COLOR_*

2017-06-02T07:57:24+00:00

This patch changes omapdrm to use DRM_FORMAT_* values instead of OMAP_DSS_COLOR_* enum. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart

drm/omap: use u32 instead of enum omap_color_mode

2017-06-02T07:57:24+00:00

In this step we drop 'enum omap_color_mode', and use u32 instead. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart