lwn.git/drivers/gpio/gpio-wcove.c, branch docs-5.17-3

gpio: wcove: Split error handling for CTRL and IRQ registers

2021-05-20T12:20:52+00:00

The wcove_gpio_dbg_show() uses one message to all possible error reads. Split it to two for CTRL and IRQ registers. While at it, switch to use dev_err() instead of pr_err(). Signed-off-by: Andy Shevchenko

gpio: wcove: Unify style of to_reg() with to_ireg()

2021-05-20T10:43:22+00:00

Use ternary and rename parameter to 'type' in to_reg() to be in the same style as to_ireg(). Signed-off-by: Andy Shevchenko

gpio: wcove: Use IRQ hardware number getter instead of direct access

2021-05-20T10:43:22+00:00

IRQ framework provides special type and getter to transform Linux IRQ to the hardware pin. Use that type and getter function instead of direct access. No functional changes intended. While at it, remove unneeded check in wcove_update_irq_ctrl() since it is guaranteed that function will be called with valid parameter. Signed-off-by: Andy Shevchenko

gpio: wcove: Split out to_ireg() helper and deduplicate the code

2021-02-15T10:43:32+00:00

There are a few places in the code where IRQ status and mask register values are being updated. Use a new exctracted helper to deduplicate the code. While at it, get rid of unnecessary divisions. Signed-off-by: Andy Shevchenko

gpio: wcove: Switch to use regmap_set_bits(), regmap_clear_bits()

2021-02-15T10:43:32+00:00

the regmap_set_bits(), regmap_clear_bits() API makes code better to understand. Switch the driver to use them, Signed-off-by: Andy Shevchenko

gpio: wcove: Get rid of error prone casting in IRQ handler

2021-02-15T10:43:32+00:00

The casting from int to long on 64-bit platform is error prone. Replace it with proper type of the variable on stack. Signed-off-by: Andy Shevchenko

gpio: wcove: convert comma to semicolon

2021-02-15T10:43:29+00:00

Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun Signed-off-by: Bartosz Golaszewski

gpio: wcove: Request IRQ after all initialisation done

2020-08-03T23:25:02+00:00

There is logically better to request IRQ when we initialise all structures. Align the driver with the rest on the same matter. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200728125504.27786-3-andriy.shevchenko@linux.intel.com Signed-off-by: Linus Walleij

gpio: wcove: Use irqchip template

2020-07-22T13:00:27+00:00

This makes the driver use the irqchip template to assign properties to the gpio_irq_chip instead of using the explicit calls to gpiochip_irqchip_add_nested() and gpiochip_set_nested_irqchip(). The irqchip is instead added while adding the gpiochip. Cc: Bin Gao Cc: Andy Shevchenko Cc: Hans de Goede Signed-off-by: Linus Walleij Tested-by: Hans de Goede Signed-off-by: Andy Shevchenko

gpio: Use new GPIO_LINE_DIRECTION

2019-11-07T08:27:48+00:00

It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. NOTE - for gpio-amd-fch and gpio-bd9571mwv: This commit also changes the return value for direction get to equal 1 for direction INPUT. Prior this commit these drivers might have returned some other positive value but 1 for INPUT. Signed-off-by: Matti Vaittinen Acked-by: Scott Branden Reviewed-by: Grygorii Strashko Reviewed-by: Michal Simek Reviewed-by: Geert Uytterhoeven Acked-by: Andy Shevchenko Acked-by: William Breathitt Gray Acked-by: Kuppuswamy Sathyanarayanan Signed-off-by: Linus Walleij