lwn.git/drivers/char/hw_random/amd-rng.c, branch standardize-docs

hwrng: amd - Revert managed API changes

2017-03-16T09:43:10+00:00

After commit 31b2a73c9c5f ("hwrng: amd - Migrate to managed API"), the amd-rng driver uses devres with pci_dev->dev to keep track of resources, but does not actually register a PCI driver. This results in the following issues: 1. The message WARNING: CPU: 2 PID: 621 at drivers/base/dd.c:349 driver_probe_device+0x38c is output when the i2c_amd756 driver loads and attempts to register a PCI driver. The PCI & device subsystems assume that no resources have been registered for the device, and the WARN_ON() triggers since amd-rng has already do so. 2. The driver leaks memory because the driver does not attach to a device. The driver only uses the PCI device as a reference. devm_*() functions will release resources on driver detach, which the amd-rng driver will never do. As a result, 3. The driver cannot be reloaded because there is always a use of the ioport and region after the first load of the driver. Revert the changes made by 31b2a73c9c5f ("hwrng: amd - Migrate to managed API"). Cc: Signed-off-by: Prarit Bhargava Fixes: 31b2a73c9c5f ("hwrng: amd - Migrate to managed API"). Cc: Matt Mackall Cc: Corentin LABBE Cc: PrasannaKumar Muralidharan Cc: Wei Yongjun Cc: linux-crypto@vger.kernel.org Cc: linux-geode@lists.infradead.org Signed-off-by: Herbert Xu

hwrng: amd - Fix return value check in mod_init()

2016-09-22T10:27:48+00:00

In case of error, the function devm_kzalloc() or devm_ioport_map() return NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 31b2a73c9c5f ("hwrng: amd - Migrate to managed API") Signed-off-by: Wei Yongjun Signed-off-by: Herbert Xu

hwrng: amd - Migrate to managed API

2016-09-13T12:27:23+00:00

Managed API eliminates error handling code, thus reduces several lines of code. Signed-off-by: PrasannaKumar Muralidharan Signed-off-by: Herbert Xu

hwrng: amd - Convert to new hwrng read() API

2016-08-31T15:00:47+00:00

This patch convert the hwrng interface used by amd768-rng to its new API by replacing data_read()/data_present() by read(). Signed-off-by: LABBE Corentin Signed-off-by: Herbert Xu

hwrng: amd - Access hardware via ioread32/iowrite32

2016-08-31T15:00:46+00:00

Instead of accessing hw directly via pmbase, it's better to access after ioport_map() via ioread32/iowrite32. Signed-off-by: LABBE Corentin Signed-off-by: Herbert Xu

hwrng: amd - Replace global variable with private struct

2016-08-31T15:00:45+00:00

Instead of having two global variable, it's better to use a private struct. This will permit to remove amd_pdev variable Signed-off-by: LABBE Corentin Signed-off-by: Herbert Xu

hwrng: amd - release_region must be called after hwrng_unregister

2016-08-31T15:00:45+00:00

The driver release the memory region before being sure that nobody use it. This patch made hwrng_unregister ran before any release was done. Signed-off-by: LABBE Corentin Signed-off-by: Herbert Xu

hwrng: amd - Remove asm/io.h

2016-08-31T15:00:44+00:00

checkpatch complains about used instead of linux/io.h. In fact it is not needed. This patch remove it, and in the process, alphabetize the other headers. Signed-off-by: LABBE Corentin Signed-off-by: Herbert Xu

hwrng: amd - Be consitent with the driver name

2016-08-31T15:00:43+00:00

The driver name is displayed each time differently. This patch make use of the same name everywhere. Signed-off-by: LABBE Corentin Signed-off-by: Herbert Xu

hwrng: amd - use the BIT macro

2016-08-31T15:00:43+00:00

This patch add usage of the BIT() macro Signed-off-by: LABBE Corentin Signed-off-by: Herbert Xu