lwn.git/drivers/ata/pata_octeon_cf.c, branch docs-6.0

ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe

2022-06-06T00:52:17+00:00

of_find_device_by_node() takes reference, we should use put_device() to release it when not need anymore. Add missing put_device() to avoid refcount leak. Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.") Signed-off-by: Miaoqian Lin Reviewed-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: Drop commas after OF match table sentinels

2022-03-07T02:49:10+00:00

It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel. Add comments to clarify the purpose of the empty elements. Rewrap entries to a single line to have a consistent style. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergey Shtylyov Acked-by: Florian Fainelli [ahci_brcm] Reviewed-by: Kieran Bingham Reviewed-by: Linus Walleij Signed-off-by: Damien Le Moal

ata: add/use ata_taskfile::{error|status} fields

2022-02-20T00:06:05+00:00

Add the explicit error and status register fields to 'struct ata_taskfile' using the anonymous *union*s ('struct ide_taskfile' had that for ages!) and update the libata taskfile code accordingly. There should be no object code changes resulting from that... Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: pata_octeon_cf: fix call to trace_ata_bmdma_stop()

2022-01-21T09:39:16+00:00

The first argument of trace_ata_bmdma_stop() must be a pointer to a struct ata_port, not to a struct ata_queued_cmd. Reported-by: Linux Kernel Functional Testing Fixes: d3e140f2b008 ("ata: pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining one") Signed-off-by: Damien Le Moal Tested-by: Linux Kernel Functional Testing

ata: pata_octeon_cf: remove redundant val variable

2022-01-14T06:17:16+00:00

Return value from DIV_ROUND_UP() directly instead of taking this in another redundant variable. Reported-by: Zeal Robot Signed-off-by: Minghao Chi Signed-off-by: CGEL ZTE Signed-off-by: Damien Le Moal

ata: pata_octeon_cf: Replace pr_XXX() calls with structured logging

2022-01-05T10:33:03+00:00

Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining one

2022-01-05T10:33:01+00:00

Drop pointless VPRINTK() calls and convert the remaining calls to the existing bmdma tracepoint. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: pata_octeon_cf: remove DPRINTK() macro in interrupt context

2022-01-05T10:33:01+00:00

There is only so much information to be glanced when the interrupt routine is called and exited, so remove these DPRINTK() calls. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: libata: tracepoints for bus-master DMA

2022-01-05T10:32:51+00:00

Add tracepoints for bus-master DMA and taskfile related functions. That allows us to drop the relevant DPRINTK() calls. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: libata: add reset tracepoints

2022-01-04T11:00:57+00:00

To follow the flow of control we should be using tracepoints, as they will tie in with the actual I/O flow and deliver a better overview about what it happening. This patch adds tracepoints for hard reset, soft reset, and postreset and adds them in the libata-eh control flow. With that we can drop the reset DPRINTK calls in the various drivers. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal